Skip to content

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 18, 2024

Description

Promotes kubernetes/enhancements#4601 to beta

/hold for kubernetes/kubernetes#128168

/sig auth

/cc @deads2k

@k8s-ci-robot k8s-ci-robot requested a review from deads2k October 18, 2024 00:29
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9fc34d7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6716b22493970d0008a9496c

Copy link

netlify bot commented Oct 18, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9fc34d7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6716b224c715340008bd47d7
😎 Deploy Preview https://deploy-preview-48411--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Oct 22, 2024

/approve
/hold cancel
The upstream change has been merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@deads2k
Copy link
Contributor

deads2k commented Oct 23, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 71b2c32729ceb8ac2f0304e98963b85750c73e98

@k8s-ci-robot k8s-ci-robot merged commit 5c2f6a8 into kubernetes:dev-1.32 Oct 23, 2024
6 checks passed
@liggitt liggitt deleted the 4601-beta branch July 1, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants