Skip to content

Conversation

ardaguclu
Copy link
Member

This PR adds new environment variable into the docs for kubernetes/enhancements#3104

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 17, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7942724
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/671f469ebf140500082ab526

@ardaguclu
Copy link
Member Author

/cc @soltysh @eddiezane

Copy link

netlify bot commented Oct 17, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7942724
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/671f469ebe35d80008085679
😎 Deploy Preview https://deploy-preview-48402--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 17, 2024

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Oct 17, 2024
<td colspan="2">KUBECTL_KUBERC</td>
</tr>
<tr>
<td></td><td style="line-height: 130%; word-wrap: break-word;">When set to true, kuberc file is taken account to define user specific preferences.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td></td><td style="line-height: 130%; word-wrap: break-word;">When set to true, kuberc file is taken account to define user specific preferences.
<td></td><td style="line-height: 130%; word-wrap: break-word;">When set to true, kuberc file is taken into account to define user specific preferences.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thank you.

@stmcginnis
Copy link
Contributor

Should wait on, but fast-follow, the merging of kubernetes/kubernetes#125230

@ardaguclu
Copy link
Member Author

ardaguclu commented Nov 8, 2024

We've missed the code merge for 1.32 and functionality is deferred to 1.33
/close

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: Closed this PR.

In response to this:

We've missed the code expect and functionality is deferred to 1.33
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants