Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4049: Add StorageCapacityScoring feature gate documents #48382

Closed

Conversation

cupnes
Copy link

@cupnes cupnes commented Oct 16, 2024

Description

This PR updates existing documentation to include the addition of the StorageCapacityScoring feature gate of KEP-4049 as an alpha version.

Issue

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chanieljdan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @cupnes!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f9e934d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/672498831dbc930008ef3917

Copy link

netlify bot commented Oct 16, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f9e934d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/672498836affee00085d3fd8
😎 Deploy Preview https://deploy-preview-48382--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cupnes cupnes changed the title [WIP] KEP-4049: Add StorageCapacityScoring feature gate to scheduler section [WIP] Add storage capacity scoring Oct 17, 2024
@cupnes cupnes changed the title [WIP] Add storage capacity scoring [WIP] KEP-4049: Add StorageCapacityScoring feature gate to scheduler section Oct 17, 2024
@cupnes cupnes force-pushed the add-storage-capacity-scoring branch from 5a6ed2b to f9e934d Compare November 1, 2024 08:59
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
@cupnes cupnes changed the title [WIP] KEP-4049: Add StorageCapacityScoring feature gate to scheduler section [WIP] KEP-4049: Add StorageCapacityScoring feature gate documents Nov 1, 2024
@cupnes cupnes changed the title [WIP] KEP-4049: Add StorageCapacityScoring feature gate documents KEP-4049: Add StorageCapacityScoring feature gate documents Nov 1, 2024
@cupnes cupnes marked this pull request as ready for review November 1, 2024 09:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2024
@cupnes cupnes requested a review from sftim November 1, 2024 09:10
@cupnes
Copy link
Author

cupnes commented Nov 1, 2024

@sftim @ahg-g @salaxander @natalisucks
I have addressed your comments and believe the work on the document is complete. Please review it. If anything is missing, let me know and I will fix it.

@tengqm
Copy link
Contributor

tengqm commented Nov 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48c2dd8d0eecfe460a810e7541e580d327e5ba19

@cupnes
Copy link
Author

cupnes commented Nov 8, 2024

The alpha of KEP-4049 will skip version 1.32 (Ref). Therefore, I will close this PR that was opened against the dev-1.32 branch of the k/website repository.

@cupnes cupnes closed this Nov 8, 2024
@cupnes cupnes deleted the add-storage-capacity-scoring branch February 14, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants