Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4420: Retry Generate Name: Promote to beta #46983

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Jun 26, 2024

This is not a user visible feature. The change is that name generation is retried automatically by the apiserver if the randomly generated hash collides an existing name. Name generation failures can still happen, and happen with the same error, but are far more rare.

For this reason, only a feature gate is being added to the documentation.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
@jpbetz jpbetz changed the base branch from main to dev-1.31 June 26, 2024 14:47
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
@jpbetz jpbetz changed the title Retry generate name beta KEP-4420: Retry Generate Name: Promote to beta Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ef82385
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667c29f0d7a5e20009ea3f08
😎 Deploy Preview https://deploy-preview-46983--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@T-Lakshmi T-Lakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8109365e486413b54780c6b46a2690261cd1eee

@T-Lakshmi
Copy link
Contributor

Here is the Preview page.

@sftim
Copy link
Contributor

sftim commented Jun 26, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit dd0de2f into kubernetes:dev-1.31 Jun 26, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants