Skip to content

Conversation

@tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 25, 2024

This PR update is just the feature gate stage since there are no user-facing changes in the beta stage.

Part of: kubernetes/enhancements#3998

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 25, 2024
@netlify
Copy link

netlify bot commented Jun 25, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f6be581
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66a24fa2a74308000889d04f

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 25, 2024
@netlify
Copy link

netlify bot commented Jun 25, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f6be581
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a24fa2d563720008738c9c
😎 Deploy Preview https://deploy-preview-46970--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Princesso
Copy link
Contributor

Hello @tenzen-y 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@carlory
Copy link
Member

carlory commented Jul 11, 2024

/hold
until kubernetes/kubernetes#126017 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@tenzen-y tenzen-y changed the title WIP: Update JobSuccessPolicy documentations for the beta graduation Update JobSuccessPolicy documentations for the beta graduation Jul 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2024
@Shubham82
Copy link
Contributor

FYI: The following upstream PR is closed kubernetes/kubernetes#126017, Instead of that kubernetes/kubernetes#126064 is opened for the same, but there is some talk to merge several PRs into one for this enhancement, Here is the comment for it: kubernetes/kubernetes#126064 (comment)
Wait until all corresponding PRs are merged.

@Princesso
Copy link
Contributor

FYI: The following upstream PR is closed kubernetes/kubernetes#126017, Instead of that kubernetes/kubernetes#126064 is opened for the same, but there is some talk to merge several PRs into one for this enhancement, Here is the comment for it: kubernetes/kubernetes#126064 (comment) Wait until all corresponding PRs are merged.

Hello @Shubham82, I noticed that all the aforementioned upstream PRs are closed. Not of them got merged. Could you kindly let us know if other PRs were opened instead?

@Shubham82
Copy link
Contributor

Shubham82 commented Jul 24, 2024

Hello @Shubham82, I noticed that all the aforementioned upstream PRs are closed. Not of them got merged. Could you kindly let us know if other PRs were opened instead?

Hi @Princesso, Here is the corresponding PR(combining all PRs into one), and it is merged now:
kubernetes/kubernetes#126067

@Shubham82
Copy link
Contributor

removing the hold label, as the corresponding Upstream PR is merged.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@Shubham82
Copy link
Contributor

Thanks @tenzen-y for the PR, The changes look good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 25a3e69e1cc1ac2913a20d9c3fcfbfc2096088ea

@hacktivist123
Copy link
Contributor

Hello @tenzen-y 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 25, 2024

Hello @tenzen-y 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

Thank you for reminding me!
/assign @atiratree @soltysh

@tenzen-y tenzen-y force-pushed the beta-graduate-job-success-policy branch from 457dc29 to f6be581 Compare July 25, 2024 13:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@tenzen-y
Copy link
Member Author

@atiratree I addressed your comments. PTAL, thanks.

@atiratree
Copy link
Member

Thanks, lgtm from sig-apps pov.

@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49b1ee60dafafce4bb9357c2768646d18526df9d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit df9b7f1 into kubernetes:dev-1.31 Jul 26, 2024
@tenzen-y tenzen-y deleted the beta-graduate-job-success-policy branch July 26, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants