-
Couldn't load subscription status.
- Fork 15.1k
Update JobSuccessPolicy documentations for the beta graduation #46970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JobSuccessPolicy documentations for the beta graduation #46970
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello @tenzen-y 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you! |
|
/hold |
|
FYI: The following upstream PR is closed kubernetes/kubernetes#126017, Instead of that kubernetes/kubernetes#126064 is opened for the same, but there is some talk to merge several PRs into one for this enhancement, Here is the comment for it: kubernetes/kubernetes#126064 (comment) |
Hello @Shubham82, I noticed that all the aforementioned upstream PRs are closed. Not of them got merged. Could you kindly let us know if other PRs were opened instead? |
Hi @Princesso, Here is the corresponding PR(combining all PRs into one), and it is merged now: |
|
removing the hold label, as the corresponding Upstream PR is merged. |
|
Thanks @tenzen-y for the PR, The changes look good to me. /lgtm |
|
LGTM label has been added. Git tree hash: 25a3e69e1cc1ac2913a20d9c3fcfbfc2096088ea
|
|
Hello @tenzen-y 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you! |
Thank you for reminding me! |
content/en/docs/reference/command-line-tools-reference/feature-gates/job-success-policy.md
Show resolved
Hide resolved
Signed-off-by: Yuki Iwai <[email protected]>
457dc29 to
f6be581
Compare
|
@atiratree I addressed your comments. PTAL, thanks. |
|
Thanks, lgtm from sig-apps pov. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 49b1ee60dafafce4bb9357c2768646d18526df9d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR update is just the feature gate stage since there are no user-facing changes in the beta stage.
Part of: kubernetes/enhancements#3998