Skip to content

WIP: Document KEP 3157 (watch-list) for milestone 1.30 #45283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: Document KEP 3157 (watch-list) for milestone 1.30 #45283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion content/en/docs/reference/command-line-tools-reference/feature-gates/watch-list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@ stages:
- stage: alpha
defaultValue: false
fromVersion: "1.27"
Copy link
Contributor

@sftim sftim Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fromVersion: "1.27"
fromVersion: "1.27"
toVersion: "1.29"

The website does not work out toVersion for you, you need to be explicit.

- stage: beta
defaultValue: true
fromVersion: "1.30"
---
Enable support for [streaming initial state of objects in watch requests](/docs/reference/using-api/api-concepts/#streaming-lists).
Enable support for [streaming initial state of objects in watch requests](/content/en/docs/reference/using-api/api-concepts.md/#streaming-lists).
Copy link
Contributor Author

@p0lyn0mial p0lyn0mial Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link was broken.

Copy link
Member

@dipesh-rawat dipesh-rawat Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested link update seems unnecessary and incorrect. The existing link works as expected when rendered on the website. I'm not sure if this update is needed.
Please check it out here: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ (check "WatchList" under the "List of feature gates" section).

The final redirection location is https://kubernetes.io/docs/reference/using-api/api-concepts/#streaming-lists.

Copy link
Contributor

@sftim sftim Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enable support for [streaming initial state of objects in watch requests](/content/en/docs/reference/using-api/api-concepts.md/#streaming-lists).
Enable support for [streaming initial state of objects in watch requests](/docs/reference/using-api/api-concepts/#streaming-lists).