Document impact of DRA on scheduling #43907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
sig/docs
38 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7315572cb02f166d75e4c522bafa581c47c64999
|
|
/sig node |
k8s-ci-robot
added
sig/node
|
/retitle Document impact of DRA on scheduling |
k8s-ci-robot
changed the title
sftim
reviewed
Nov 14, 2023
Comment on lines
165
to
173
| {{< warning >}} | ||
|
|
||
| Scheduling of pods which use ResourceClaims is going to be slower because of | ||
| the additional communication that is required. Beware that this may also impact | ||
| pods that don't use ResourceClaims because only one pod at a time gets | ||
| scheduled, blocking API calls are made while handling a pod with | ||
| ResourceClaims, and thus scheduling the next pod gets delayed. | ||
|
|
||
| {{< /warning >}} |
There was a problem hiding this comment.
Try this:
Suggested change
| {{< warning >}} | |
| Scheduling of pods which use ResourceClaims is going to be slower because of | |
| the additional communication that is required. Beware that this may also impact | |
| pods that don't use ResourceClaims because only one pod at a time gets | |
| scheduled, blocking API calls are made while handling a pod with | |
| ResourceClaims, and thus scheduling the next pod gets delayed. | |
| {{< /warning >}} | |
| {{< note >}} | |
| Scheduling of pods that use ResourceClaims is going to be slower because of | |
| the additional communication that is required. Beware that using ResourceClaims | |
| in your cluster may also impact scheduling of pods that don't use ResourceClaims. | |
| This impact happens because the kube-scheduler schedules one pod at a time; | |
| blocking API calls are made while handling a pod with ResourceClaims, and thus | |
| scheduling for other Pods in the scheduling queue is also delayed. | |
| {{< /note >}} |
Don't use a warning; it's not the best fit for this level of advice.
Once DRA is beta, we might want to add a one-line mention in https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ about potential sources of scheduling delays, and link to this page for more detail of how DRA can contribute there.
There was a problem hiding this comment.
Changed to note and created an issue to track updating pod-lifecycle.
There was a problem hiding this comment.
(the suggestion also proposed a wording tweak, though it's not immediately obvious from the diff)
That pods with ResourceClaims get scheduled more slowly, but that this also affects other pods may be surprising and is worth calling out.
pohly
force-pushed
the
dra-scheduling-impact
branch
from
252dc35
to
725f68f
Compare
k8s-ci-robot
removed
the
lgtm
sftim
reviewed
Nov 14, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: baa251f2148d1908cdb3b3137b917d2823833de4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That pods with ResourceClaims get scheduled more slowly, but that this also affects other pods may be surprising and is worth calling out.