Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1880 Multiple ServiceCIDR #43469

Merged
merged 1 commit into from
Nov 29, 2023
Merged

KEP-1880 Multiple ServiceCIDR #43469

merged 1 commit into from
Nov 29, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Oct 13, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2023
@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 53982e5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65301e5d2a9df3000874a1a4
😎 Deploy Preview https://deploy-preview-43469--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 13, 2023

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Oct 13, 2023
@aojea aojea mentioned this pull request Oct 18, 2023
Open
8 tasks
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2023
@aojea aojea changed the base branch from main to dev-1.29 October 18, 2023 18:05
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit dff94b8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/656683a43f53240008ebc332

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 18, 2023
@harshitasao
Copy link
Contributor

Hi @aojea , Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023.
Thank you!

@katcosgrove
Copy link
Contributor

Hi, @aojea ! Just dropping by to remind you that the deadline for docs PRs to be ready for review is today, November 14. Is there anything we can help you with to get this PR ready?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@aojea aojea changed the title [WIP] Add Placeholder for KEP-1880 Multiple ServiceCIDR KEP-1880 Multiple ServiceCIDR Nov 14, 2023
sftim
sftim reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization teams will thank you if the Markdown source is wrapped; I use 93 characters per line, but you can pick anything so long as it avoids very long lines.

/lgtm

I'd like to see the last couple of details addressed.

content/en/docs/tasks/network/extend-service-ip-ranges.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45b878fcc0a94808c5af7765199fcdaf921d5b90

@kbhawkey
Copy link
Contributor

/lgtm

@drewhagen
Copy link
Member

/lgtm

@kbhawkey
Copy link
Contributor

kbhawkey commented Nov 29, 2023 •
edited
Loading

Page preview:
https://deploy-preview-43469--kubernetes-io-vnext-staging.netlify.app/docs/reference/networking/virtual-ips/#ip-address-allocation-tracking

https://deploy-preview-43469--kubernetes-io-vnext-staging.netlify.app/docs/tasks/network/extend-service-ip-ranges/

https://deploy-preview-43469--kubernetes-io-vnext-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/

@kbhawkey
Copy link
Contributor

These changes seem good enough to merge. Are there objections?

@drewhagen
Copy link
Member

drewhagen commented Nov 29, 2023 •
edited
Loading

@kbhawkey Considering this is an alpha feature, I would agree. Would @sftim's remaining feedback be easily accounted for in a follow-up?
Otherwise, it is very late in @aojea 's timezone, so corrections would be reasonably expected tomorrow.

@kbhawkey
Copy link
Contributor

Let's move this PR forward.
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@sftim
Copy link
Contributor

sftim commented Nov 29, 2023

Final LGTM!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6060e7d3ea1318b012b1ef8d05621f901823b59f

@drewhagen
Copy link
Member

/lgtm

@sftim
Copy link
Contributor

sftim commented Nov 29, 2023

Thanks for the responsive updates @aojea - and for documenting this nice improvement to Kubernetes.

@drewhagen
Copy link
Member

Great work today @aojea!
As a frequent reader of the Kubernetes docs, I appreciate your contribution 😄

@k8s-ci-robot k8s-ci-robot merged commit 0401617 into kubernetes:dev-1.29 Nov 29, 2023
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 29, 2023
@sftim sftim mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@drewhagen drewhagen Awaiting requested review from drewhagen

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@sftim sftim Awaiting requested review from sftim

Assignees

@danwinship danwinship

@kbhawkey kbhawkey

@drewhagen drewhagen

@thockin thockin

@katcosgrove katcosgrove

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
10 participants
@aojea @sftim @harshitasao @katcosgrove @danwinship @k8s-ci-robot @kbhawkey @drewhagen @tengqm @thockin