Skip to content

[WIP] Document KubeletEnsureSecretPulledImages feature #43454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] Document KubeletEnsureSecretPulledImages feature #43454

wants to merge 1 commit into from

Conversation

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 12, 2023

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e04d867
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/652800b78fb9190009eac527

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2023
@pacoxu pacoxu mentioned this pull request Oct 12, 2023
Open
23 tasks
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign katcosgrove for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 12, 2023
@dipesh-rawat
Copy link
Member

dipesh-rawat commented Oct 12, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 12, 2023
tengqm
tengqm reviewed Oct 12, 2023
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
| `KMSv2KDF` | `false` | Beta | 1.28 | |
| `KubeProxyDrainingTerminatingNodes` | `false` | Alpha | 1.28 | |
| `KubeletCgroupDriverFromCRI` | `false` | Alpha | 1.28 | |
| `KubeletEnsureSecretPulledImages` | `false` | Alpha | 1.29 | |
Copy link
Contributor

@tengqm tengqm Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each and every gate needs a description that can be found at the end of this file, in alphabeta order.

@sftim
Copy link
Contributor

sftim commented Oct 12, 2023

/retitle [WIP] Document KubeletEnsureSecretPulledImages feature

so that Prow knows it's a draft

@k8s-ci-robot k8s-ci-robot changed the title [placeholder] Add KubeletEnsureSecretPulledImages [WIP] Document KubeletEnsureSecretPulledImages feature Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
sftim
sftim reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Some early feedback - I know this is a work in progress.

content/en/docs/reference/command-line-tools-reference/feature-gates.md
the `cgroupDriver` configuration setting.
See [Configuring a cgroup driver](/docs/tasks/administer-cluster/kubeadm/configure-cgroup-driver)
for more details.
- `KubeletEnsureSecretPulledImages`: add support in kubelet for the `pullIfNotPresent`
Copy link
Contributor

@sftim sftim Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `KubeletEnsureSecretPulledImages`: add support in kubelet for the `pullIfNotPresent`
- `KubeletEnsureSecretPulledImages`: change the behavior of the `IfNotPresent`

content/en/docs/reference/command-line-tools-reference/feature-gates.md
Comment on lines +590 to +591
for other pods that do not have the same `imagePullSecret`/auths used to successfully pull
the images in the first place.
Copy link
Contributor

@sftim sftim Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for other pods that do not have the same `imagePullSecret`/auths used to successfully pull
the images in the first place.
for other pods that do not have the same `imagePullSecret` authentication information that was used
to retrieve that Pod's container image(s) in the first place.

content/en/docs/reference/command-line-tools-reference/feature-gates.md
Comment on lines +592 to +593
This policy change will have no affect on the pull always image pull policy or for images
that are preloaded.
Copy link
Contributor

@sftim sftim Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This policy change will have no affect on the pull always image pull policy or for images
that are preloaded.
Enabling this feature gate has no effect on Pods that use the `Always` image pull policy, nor for the
`Never` image pull policy or for container images that are preloaded onto the target node.

@pacoxu
Copy link
Member Author

pacoxu commented Nov 10, 2023

@sftim thanks for your comments. However, the PR for k/k is not merged yet. This will be postponed to v1.30.

I will open a new PR for v1.30 later. I will update it according to your comments in the new PR. Thanks.

@pacoxu pacoxu closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@windsonsea windsonsea Awaiting requested review from windsonsea

+1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

1.29

Development

Successfully merging this pull request may close these issues.

5 participants

@pacoxu @k8s-ci-robot @dipesh-rawat @sftim @tengqm