Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an entry in glossary for MVP #42186

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Add an entry in glossary for MVP #42186

merged 1 commit into from
Aug 5, 2023

Conversation

richabanker
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2023
@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 551bb8e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64c15d6a0987da00083c0a9e

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 24, 2023
This was referenced Jul 24, 2023
Merged
Closed
@Ritikaa96
Copy link
Contributor

Thanks for adding this @richabanker
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc965f0ec651a221173ba0c4c53678317af16ee5

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Ritikaa96 July 26, 2023 17:52
@richabanker richabanker changed the title Add an entry in glossary for UVIP Add an entry in glossary for MVP Jul 26, 2023
@Ritikaa96
Copy link
Contributor

I get the name was changed as per discussion here
Is the feature gate: UnknownVersionInteroperabilityProxy in the process to be renamed as well?

@Ritikaa96
Copy link
Contributor

This LGTM, thanks @richabanker
/lgtm
However I'd still like to know if:

I get the name was changed as per discussion here
Is the feature gate: UnknownVersionInteroperabilityProxy in the process to be renamed as well?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 358d4a6912101d3ac622333edc3feb3fbb4cf417

@richabanker
Copy link
Contributor Author

This LGTM, thanks @richabanker /lgtm However I'd still like to know if:

I get the name was changed as per discussion here
Is the feature gate: UnknownVersionInteroperabilityProxy in the process to be renamed as well?

Thanks @Ritikaa96
Looks like we may have to stick with the original name (UnknownVersionInteroperabilityProxy) for the feature gate according to @jpbetz's response here

@Ritikaa96
Copy link
Contributor

This LGTM, thanks @richabanker /lgtm However I'd still like to know if:

I get the name was changed as per discussion here
Is the feature gate: UnknownVersionInteroperabilityProxy in the process to be renamed as well?

Thanks @Ritikaa96 Looks like we may have to stick with the original name (UnknownVersionInteroperabilityProxy) for the feature gate according to @jpbetz's response here

Right. I prefer consistency as well though I understand it's due to the code freeze. 👍🏼

@sftim sftim mentioned this pull request Aug 4, 2023
Merged
sftim
sftim reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

content/en/docs/reference/glossary/mixed-version-proxy.md
feature enables resource requests to be served by the correct API server.

MVP is disabled by default and can be activated by enabling
the feature gate named `UnknownVersionInteroperabilityProxy` when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's better to hyperlink to https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this change in #42410

content/en/docs/reference/glossary/mixed-version-proxy.md

MVP is disabled by default and can be activated by enabling
the feature gate named `UnknownVersionInteroperabilityProxy` when
{{< glossary_tooltip text="API Server" term_id="kube-apiserver" >}} is started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< glossary_tooltip text="API Server" term_id="kube-apiserver" >}} is started.
the {{< glossary_tooltip text="API Server" term_id="kube-apiserver" >}} is started.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this change in #42410

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d03e49 into kubernetes:dev-1.28 Aug 5, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#42186 from Richabanker/uvip-glossary
9b173be 
Add an entry in glossary for MVP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@Ritikaa96 Ritikaa96 Awaiting requested review from Ritikaa96

Assignees

@Ritikaa96 Ritikaa96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@richabanker @Ritikaa96 @k8s-ci-robot @sftim