Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for PersistentVolume last phase transition time #42008

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add docs for PersistentVolume last phase transition time #42008

merged 1 commit into from
Aug 4, 2023

Conversation

RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Jul 13, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 13, 2023
@RomanBednar RomanBednar mentioned this pull request Jul 13, 2023
Open
12 tasks
@katcosgrove
Copy link
Contributor

Hello @RomanBednar 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

@RomanBednar
Copy link
Contributor Author

@katcosgrove Thank you for the reminder, I'm aware of the deadline but unfortunately wasn't able to find enough time for this due to other (internal) priorities. Is there a process for adding the doc later or does it have to wait for the next release?

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-doc branch from 12d88f7 to 9538d69 Compare August 1, 2023 14:14
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 8d7f7fd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64cb6d4225a9660008ba82c1

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2023
@RomanBednar RomanBednar changed the title WIP: Add docs for PersistentVolume last phase transition time Add docs for PersistentVolume last phase transition time Aug 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@RomanBednar
Copy link
Contributor Author

@jsafrane please review from technical side

@katcosgrove I was able to update the PR since the deadline moved to 8th of August, can you please review it?

@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-doc branch from 9538d69 to 1d09feb Compare August 2, 2023 09:40
@tengqm
Copy link
Contributor

tengqm commented Aug 3, 2023

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@RomanBednar RomanBednar force-pushed the pv-last-phase-transition-time-doc branch from 1883b21 to 8d7f7fd Compare August 3, 2023 09:02
@windsonsea
Copy link
Member

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5d2134e804e1523fa09e1671269142bec5cb24d

@k8s-ci-robot k8s-ci-robot merged commit 0084a63 into kubernetes:dev-1.28 Aug 4, 2023
4 checks passed
@sftim sftim mentioned this pull request Aug 12, 2023
Merged
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@RomanBednar @Rishit-dagli
Add docs for PersistentVolume last phase transition time (kubernetes#…
34475fe 
…42008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@tengqm tengqm tengqm left review comments

@msau42 msau42 Awaiting requested review from msau42

@thockin thockin Awaiting requested review from thockin

Assignees

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@RomanBednar @katcosgrove @tengqm @k8s-ci-robot @windsonsea @jsafrane