Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic resource allocation: update for 1.27 #40086

Merged
merged 1 commit into from
Mar 17, 2023
Merged

dynamic resource allocation: update for 1.27 #40086

merged 1 commit into from
Mar 17, 2023

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 17, 2023

The API group was bumped to make some incompatible internal changes and the user-visible renaming of PodScheduling to PodSchedulingContext.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2023
@pohly pohly mentioned this pull request Mar 17, 2023
Open
38 tasks
@netlify
Copy link

netlify bot commented Mar 17, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2be8294
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6414518db3018400089730c7
😎 Deploy Preview https://deploy-preview-40086--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@klueska
Copy link
Contributor

klueska commented Mar 17, 2023

/approve
/lgtm

(as sig-node approver)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2023
sftim
sftim reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs, with a nit

Ready for tech review

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2023
@klueska
Copy link
Contributor

klueska commented Mar 17, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2023
@sftim
Copy link
Contributor

sftim commented Mar 17, 2023

/approve

@sftim
Copy link
Contributor

sftim commented Mar 17, 2023

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2023
@sftim
Copy link
Contributor

sftim commented Mar 17, 2023

This targets the wrong branch. 😅 💦

We need these changes to target dev-1.27

@sftim
Copy link
Contributor

sftim commented Mar 17, 2023

/approve cancel
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2023
@pohly pohly changed the base branch from main to dev-1.27 March 17, 2023 19:28
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2023
@k8s-ci-robot k8s-ci-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2023
@pohly
Copy link
Contributor Author

pohly commented Mar 17, 2023

This targets the wrong branch.

This always confused me - sorry. Caught in time, though! 👍

Rebased and base updated in the PR.

@pohly
dynamic resource allocation: update for 1.27
5beb348 
The API group was bumped to make some incompatible internal changes and the
user-visible renaming of PodScheduling to PodSchedulingContext.
@sftim
Copy link
Contributor

sftim commented Mar 17, 2023

/hold cancel

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2aa958fc92667774a689edfd4bd3252a1ddf009d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 955b498 into kubernetes:dev-1.27 Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@klueska klueska Awaiting requested review from klueska

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@klueska klueska

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
4 participants
@pohly @klueska @sftim @k8s-ci-robot