Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2053] Add docs for DownwardAPIHugepages graduation #39905

Merged
merged 1 commit into from
Mar 22, 2023
Merged

[KEP-2053] Add docs for DownwardAPIHugepages graduation #39905

merged 1 commit into from
Mar 22, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 10, 2023 •
edited
Loading

Placeholder PR for kubernetes/enhancements#2053

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2023
@saschagrunert saschagrunert mentioned this pull request Mar 10, 2023
Closed
6 tasks
@sftim
Copy link
Contributor

sftim commented Mar 10, 2023

/sig node
/retitle [WIP] [KEP-2053] Add docs for DownwardAPIHugepages graduation

@k8s-ci-robot k8s-ci-robot changed the title [KEP-2053] Add docs for DownwardAPIHugepages graduation [WIP] [KEP-2053] Add docs for DownwardAPIHugepages graduation Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 10, 2023
@mickeyboxell
Copy link
Contributor

Hi @saschagrunert 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@saschagrunert saschagrunert force-pushed the dev-1.27-downward-api-hugepages branch from e2cb1c0 to 9011787 Compare March 21, 2023 07:32
@saschagrunert saschagrunert changed the title [WIP] [KEP-2053] Add docs for DownwardAPIHugepages graduation [KEP-2053] Add docs for DownwardAPIHugepages graduation Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 21, 2023
@saschagrunert
Copy link
Member Author

Ready for review.

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@saschagrunert saschagrunert force-pushed the dev-1.27-downward-api-hugepages branch from 9011787 to bcff6ab Compare March 22, 2023 09:01
@tengqm
Copy link
Contributor

tengqm commented Mar 22, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4ad21ede2e95f7785b403af6ebf3a494ebd614f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit b399d83 into kubernetes:dev-1.27 Mar 22, 2023
@saschagrunert saschagrunert deleted the dev-1.27-downward-api-hugepages branch March 22, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @sftim @mickeyboxell @tengqm @k8s-ci-robot