Skip to content

Memory QOS Alpha2 KEP 2570 blog post #39853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2023
Merged

Memory QOS Alpha2 KEP 2570 blog post #39853

merged 2 commits into from
May 2, 2023

Conversation

@ndixita
Copy link
Contributor

@ndixita ndixita commented Mar 8, 2023 •
edited
Loading

Blog post of Memory QOS Alpha2 changes in v1.27

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from onlydole March 8, 2023 06:54
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm March 8, 2023 06:54
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 8, 2023
@ndixita
Copy link
Contributor Author

ndixita commented Mar 8, 2023

/assign @pacoxu @xiaoxubeii

@pacoxu pacoxu mentioned this pull request Mar 23, 2023
Open
8 tasks
@netlify
Copy link

netlify bot commented Apr 2, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit be1de2e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/643d9af3448e29000825d2a9

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2023
@ndixita ndixita changed the title WIP blog post placeholder for KEP-2570: Memory QOS Alpha2 Memory QOS Alpha2 KEP 2570 blog post Apr 2, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2023
@ndixita
Copy link
Contributor Author

ndixita commented Apr 2, 2023

/assign @bobbypage

pacoxu
pacoxu reviewed Apr 3, 2023
View reviewed changes
pacoxu
pacoxu reviewed Apr 3, 2023
View reviewed changes
tengqm
tengqm reviewed Apr 3, 2023
View reviewed changes
@ndixita ndixita force-pushed the dev-1.27 branch 4 times, most recently from 2bee1be to f447bd3 Compare April 3, 2023 21:15
tengqm
tengqm reviewed Apr 13, 2023
View reviewed changes
@tengqm
Copy link
Contributor

tengqm commented Apr 13, 2023

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2023
samuelkarp
samuelkarp approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions, but this is a great write-up!

sftim
sftim reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date assigned
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2023
sftim
sftim reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback

content/en/blog/_posts/2023-05-05-memory-qos-cgroups-v2/index.md
$memory.min = \sum_{i=0}^{no. of pods}pod.spec.containers[i].resources.requests[memory]$

`memory.min` in node level cgroup:
$memory.min = \sum_{i}^{no. of nodes}\sum_{j}^{no. of pods}pod[i].spec.containers[j].resources.requests[memory]$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be easier to read as an SVG formula with alt text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me in the preview. Also, it will make it look more consistent to either use SVG for all, or use markdown foll all. Attaching ss. Thoughts?
Screenshot 2023-04-17 at 11 49 29 AM

@sftim sftim mentioned this pull request Apr 13, 2023
Merged
@ndixita ndixita force-pushed the dev-1.27 branch 7 times, most recently from 459cffa to 944d7f6 Compare April 17, 2023 19:10
@sftim
Copy link
Contributor

sftim commented Apr 27, 2023

/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 27, 2023
@sftim
Copy link
Contributor

sftim commented Apr 27, 2023

/lgtm

If we add math formula support, we could revisit the article.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f377a31d0b141188cfe6717d6d0cb652ca5f12e3

sftim
sftim reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samuelkarp, sftim, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented May 2, 2023

/remove-label tide/merge-method-squash

@k8s-ci-robot
Copy link
Contributor

@sftim: Those labels are not set on the issue: tide/merge-method-squash

In response to this:

/remove-label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented May 2, 2023

Looks like a Netlify bug.

@sftim sftim merged commit 41a64bd into kubernetes:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@onlydole onlydole Awaiting requested review from onlydole

@pacoxu pacoxu Awaiting requested review from pacoxu

@bobbypage bobbypage Awaiting requested review from bobbypage

@xiaoxubeii xiaoxubeii Awaiting requested review from xiaoxubeii

+2 more reviewers

@sftim sftim sftim left review comments

@samuelkarp samuelkarp samuelkarp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bobbypage bobbypage

@xiaoxubeii xiaoxubeii

@pacoxu pacoxu

@tengqm tengqm

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

SIG Docs Blog Project Board
Status: Published

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.