Skip to content

Kubernetes 1.27: CSI node expand secret support moves to Beta #39834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Kubernetes 1.27: CSI node expand secret support moves to Beta #39834

wants to merge 1 commit into from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Mar 7, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@humblec
Copy link
Contributor Author

humblec commented Mar 7, 2023

Cc @xing-yang place holder PR for CSI node expand secret blog

@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 27a31a2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/644684c921d97d00084c266f
😎 Deploy Preview https://deploy-preview-39834--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@harshitasao
Copy link
Contributor

harshitasao commented Mar 24, 2023 •
edited
Loading

Hello, Comms Lead for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is on 4th of April- the sooner the better since there's still editing to be done afterwards. Any doubt, the Comms team is here to help.
Thank you!

@harshitasao
Copy link
Contributor

Hello @humblec, we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you!

@humblec
Copy link
Contributor Author

humblec commented Apr 3, 2023

Hello @humblec, we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you!

Yeah.. trying best to collect an initial draft ready in a couple of days time..

@harshitasao
Copy link
Contributor

@humblec
Reminder: The feature blog ready to review deadline is tomorrow (April 4th)

@humblec humblec force-pushed the blog-node-expansion-secret-blog branch from 0229f1b to 209f8cc Compare April 4, 2023 12:16
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2023
@humblec humblec force-pushed the blog-node-expansion-secret-blog branch from 209f8cc to 70ba675 Compare April 4, 2023 13:06
@humblec humblec changed the title [WIP] Kubernetes 1.27: CSI node expand secret support moves to Beta Kubernetes 1.27: CSI node expand secret support moves to Beta Apr 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
sftim
sftim reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
pending assignment of a publication date

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2023
@harshitasao
Copy link
Contributor

Hello, Comms Lead for v1.27 here. The publication order and date for the Feature Blog series has been finalized and the tracking board is updated.

The publication date for this article is 27-04-2023 (April 27).

Thank you!

@humblec
Copy link
Contributor Author

humblec commented Apr 10, 2023

Ack on publication date.

harshitasao
harshitasao reviewed Apr 11, 2023
View reviewed changes
sftim
sftim suggested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

At the moment I'm reviewing this, the article hasn't reached the level of finish that we'd want to accept it for publication. I've made some suggestions.

sftim
sftim reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

At the moment I'm reviewing this, the article hasn't reached the level of finish that we'd want to accept it for publication. I've made some suggestions.

@xing-yang
Copy link
Contributor

/assign

@humblec humblec force-pushed the blog-node-expansion-secret-blog branch from 70ba675 to 1979bf8 Compare April 14, 2023 16:30
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2023

@sftim thanks for the review as always !
I have accepted the suggestions and updated as per the review comments.. ptal .. thanks!

@humblec humblec force-pushed the blog-node-expansion-secret-blog branch 2 times, most recently from b805c1f to e77c8f9 Compare April 14, 2023 16:37
@humblec humblec requested a review from sftim April 18, 2023 06:08
@harshitasao
Copy link
Contributor

/lgtm
Comms View

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2023
sftim
sftim reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Here's some more feedback.

As this isn't ready for merge, I expect we'll either need to drop the article or get a new publication date assigned (possibly swapping with a later article that is already OK to publish).

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@harshitasao
Copy link
Contributor

Hi. Here's some more feedback.

As this isn't ready for merge, I expect we'll either need to drop the article or get a new publication date assigned (possibly swapping with a later article that is already OK to publish).

/lgtm cancel

@sftim I think we can swap this with this article, which is scheduled to be published on May 1 and is ready. Let me know what you think.

@humblec humblec force-pushed the blog-node-expansion-secret-blog branch from e77c8f9 to 55ec663 Compare April 24, 2023 13:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@humblec humblec force-pushed the blog-node-expansion-secret-blog branch from 55ec663 to 27a31a2 Compare April 24, 2023 13:31
@humblec
Copy link
Contributor Author

humblec commented Apr 24, 2023 •
edited
Loading

Eventhough all review comments are addressed - @harshitasao I think its fine to drop this article from publishing . We can publish this article with GA of this feature which is targeted for next release ie v1.28.

@harshitasao
Copy link
Contributor

Eventhough all review comments are addressed - @harshitasao I think its fine to drop this article from publishing . We can publish this article with GA of this feature which is targeted for next release ie v1.28.

Acknowledged

@sftim
Copy link
Contributor

sftim commented May 3, 2023

I'll close this for now. Feel free to open a new PR in the future.

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

I'll close this for now. Feel free to open a new PR in the future.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@harshitasao harshitasao Awaiting requested review from harshitasao

@xing-yang xing-yang Awaiting requested review from xing-yang

1 more reviewer

@sftim sftim sftim requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xing-yang xing-yang

@sftim sftim

@harshitasao harshitasao

Labels

area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@humblec @harshitasao @xing-yang @k8s-ci-robot @sftim