-
Notifications
You must be signed in to change notification settings - Fork 15k
Feature blog for StatefulSet Autodelete beta graduation #39819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, Comms Shadow for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is 4th of April- the sooner the better since there's still editing to be done afterwards 😃 Any doubt, the Comms team is here to help. CC @harshitasao |
Sounds good, I'll get on it, thanks for the ping. |
Hello @mattcary, we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you! |
Time flies! I've enclosed a draft. It's heavily based on the alpha blog post --- but that was from a year and a half ago, so it's probably ok (?). Thanks |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site settings. |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
A few thoughts.
|
||
**Author:** Matthew Cary (Google) | ||
|
||
Kubernetes v1.27 graduates to beta a new policy for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes v1.27 graduates to beta a new policy for | |
Kubernetes v1.27 graduated to beta a new policy mechanism for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
## What’s next? | ||
|
||
Try it out! The beta Enable the `StatefulSetAutoDeletePVC` feature gate is enabled by default on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try it out! The beta Enable the `StatefulSetAutoDeletePVC` feature gate is enabled by default on | |
Try it out! The `StatefulSetAutoDeletePVC` feature gate is beta and enabled by default on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
## What’s next? | ||
|
||
Try it out! The beta Enable the `StatefulSetAutoDeletePVC` feature gate is enabled by default on | ||
cluster versions 1.27 and greater. Create a StatefulSet using the new policy, test it out and tell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cluster versions 1.27 and greater. Create a StatefulSet using the new policy, test it out and tell | |
clusters running Kubernetes 1.27. Create a StatefulSet using the new policy, test it out and tell |
Don't promise or imply that all future minor versions have this feature gate; that's unlikely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops good point done.
us what you think! | ||
|
||
I'm very curious to see if this owner reference mechanism works well in practice. For example, I | ||
realized there is no mechanism in Kubernetes for knowing who set a reference, so it’s possible that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server Side Apply, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that's a good idea. I wish you had reviewed the KEP :-)
I'll have to try that out---even if current controller don't use it, using it here could clean things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
pending assignment of publication date
Hello, Comms Lead for v1.27 here. The publication order and date for the Feature Blog series has been finalized and the tracking board is updated. The publication date for this article is 04-05-2023 (May 04). Thank you! |
Updated! |
--- | ||
layout: blog | ||
title: 'Kubernetes 1.27: StatefulSet PVC Auto-Deletion (beta)' | ||
date: 04-05-2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 05-04-2023 (May 04)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched to year-first date so there's no ambiguity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some minor suggestions.
are scaled down. | ||
|
||
## What problem does this solve? | ||
A StatefulSet spec can include Pod and PVC templates. When a replica is first created, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we ever choose to add markdown linting, technically there should be a line break between the title and content lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
A StatefulSet spec can include Pod and PVC templates. When a replica is first created, the | ||
Kubernetes control plane creates a PVC for that replica if one does not already exist. The behavior | ||
before the PVC retention policy was that the control plane never cleaned up the PVCs created for | ||
StatefulSets - this was left up to the cluster administrator, or to some add-on automation that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to format (StatefulSets
) the Kubernetes objects throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* **`whenDeleted` and `whenScaled` are both `Retain`.** This matches the existing behavior for | ||
StatefulSets, where no PVCs are deleted. This is also the default retention policy. It’s | ||
appropriate to use when data on StatefulSet volumes may be irreplaceable and should only be | ||
deleted manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **`whenDeleted` and `whenScaled` are both `Retain`.** This matches the existing behavior for | |
StatefulSets, where no PVCs are deleted. This is also the default retention policy. It’s | |
appropriate to use when data on StatefulSet volumes may be irreplaceable and should only be | |
deleted manually. | |
* **`whenDeleted` and `whenScaled` are both `Retain`.** | |
This matches the existing behavior for | |
StatefulSets, where no PVCs are deleted. This is also the default retention policy. It’s | |
appropriate to use when data on StatefulSet volumes may be irreplaceable and should only be | |
deleted manually. |
I think separating the condition statement from the description for all of these would make this easier to parse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/lgtm Thanks! |
LGTM label has been added. Git tree hash: f59339cd72c8fbb1709140ca30a3a0d1224f3648
|
thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Date looks right
/hold cancel
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will |
See the alpha blog post for content.