Skip to content

WindowsHostNetwork alpha updates #37672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

WindowsHostNetwork alpha updates #37672

merged 1 commit into from
Nov 29, 2022
+14 −2

Conversation

@marosset
Copy link
Contributor

@marosset marosset commented Nov 2, 2022

Signed-off-by: Mark Rossetti [email protected]

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2022
@netlify
Copy link

netlify bot commented Nov 2, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b95fb30
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/638506c6ab63c900083d2c43

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 2, 2022
@marosset
Copy link
Contributor Author

marosset commented Nov 2, 2022

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 2, 2022
@marosset
Copy link
Contributor Author

marosset commented Nov 2, 2022

Part of kubernetes/enhancements#3503

@marosset marosset mentioned this pull request Nov 2, 2022
Closed
8 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2022
@marosset marosset force-pushed the windows-host-networking-alpha branch from 8b2466e to 25cebb3 Compare November 14, 2022 20:32
@marosset marosset marked this pull request as ready for review November 14, 2022 21:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2022
tengqm
tengqm reviewed Nov 23, 2022
View reviewed changes
@krol3
Copy link
Contributor

krol3 commented Nov 28, 2022

Hi @marosset! This PR needs a doc review by Mon Nov 28th to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@marosset marosset force-pushed the windows-host-networking-alpha branch from 25cebb3 to b95fb30 Compare November 28, 2022 19:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@jsturtevant
Copy link
Contributor

jsturtevant commented Nov 28, 2022 •
edited
Loading

/lgtm
for sig-windows

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b7f2d5c3c084e93e588d3ec16aa5d38fcb2f75d

@tengqm
Copy link
Contributor

tengqm commented Nov 29, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5b8e630 into kubernetes:dev-1.26 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@onlydole onlydole Awaiting requested review from onlydole

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@jsturtevant jsturtevant

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

[sig-windows] PR tracking
Status: Done

Milestone

1.26

Development

Successfully merging this pull request may close these issues.

5 participants

@marosset @krol3 @jsturtevant @k8s-ci-robot @tengqm