Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typo in korean docs fixed: Fix 02 #35248

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Minor typo in korean docs fixed: Fix 02 #35248

merged 1 commit into from
Jul 25, 2022

Conversation

nitishfy
Copy link
Member

@nitishfy nitishfy commented Jul 22, 2022 •
edited
Loading

Fix: #34909

Note: The 2nd change has been applied. The first change has been in separate PR(#35085)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ko Issues or PRs related to Korean language labels Jul 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from jmyung and pjhwa July 22, 2022 15:08
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 22, 2022
@nitishfy nitishfy mentioned this pull request Jul 22, 2022
Closed
@netlify
Copy link

netlify bot commented Jul 22, 2022

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 469c4b4
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62dabd56fb096c0008009942
😎 Deploy Preview https://deploy-preview-35248--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim
Copy link
Contributor

sftim commented Jul 22, 2022

Change LGTM

@seokho-son
Copy link
Member

Thanks !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed6494b13701428e73af283f80ba48e1ac06165f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6285db2 into kubernetes:dev-1.24-ko.2 Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmyung jmyung Awaiting requested review from jmyung

@pjhwa pjhwa Awaiting requested review from pjhwa

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitishfy @sftim @seokho-son @k8s-ci-robot