[ko] Update outdated files in `dev-1.23-ko.2` (M25-M39) #31761

jihoon-seo · 2022-02-16T03:08:01Z

한 PR에 너무 많은 변경사항을 포함시키면 리뷰하기 어려울 수 있어서, 적절히 분할하여 올립니다. 😊

Related issue: Outdated Korean contents in the dev-1.23-ko.2 #31647 (dev-1.23-ko.2)

15 files to be modified

M25. content/en/docs/concepts/services-networking/service-traffic-policy.md | 4(+XS) 4(-)

M26. content/en/docs/concepts/services-networking/service.md | 13(+S) 9(-)

M27. content/en/docs/concepts/storage/persistent-volumes.md | 24(+S) 14(-)

M28. content/en/docs/concepts/storage/storage-classes.md | 2(+XS) 2(-)

M29. content/en/docs/concepts/storage/volume-snapshot-classes.md | 4(+XS) 0(-)

M30. content/en/docs/concepts/storage/volumes.md | 2(+XS) 1(-)

M31. content/en/docs/concepts/workloads/controllers/deployment.md | 32(+M) 11(-)

M32. content/en/docs/concepts/workloads/controllers/job.md | 1(+XS) 1(-)

M33. content/en/docs/concepts/workloads/controllers/replicaset.md | 1(+XS) 1(-)

M34. content/en/docs/concepts/workloads/controllers/replicationcontroller.md | 1(+XS) 1(-)

M35. content/en/docs/concepts/workloads/pods/pod-lifecycle.md | 1(+XS) 1(-)

M36. content/en/docs/contribute/advanced.md | 4(+XS) 4(-)

M37. content/en/docs/contribute/participate/roles-and-responsibilities.md | 2(+XS) 2(-)

M38. content/en/docs/contribute/review/for-approvers.md | 1(+XS) 1(-)

M39. content/en/docs/contribute/review/reviewing-prs.md | 5(+XS) 1(-)

/language ko

netlify · 2022-02-16T03:22:40Z

✅ Deploy Preview for k8s-dev-ko ready!

🔨 Explore the source changes: ce19161

🔍 Inspect the deploy log: https://app.netlify.com/sites/k8s-dev-ko/deploys/623814ff96660d0009bf4afb

😎 Browse the preview: https://deploy-preview-31761--k8s-dev-ko.netlify.app

content/ko/docs/concepts/services-networking/service-traffic-policy.md

ianychoi · 2022-03-05T06:57:34Z

content/ko/docs/concepts/services-networking/service.md

-보다 간단한 `{SVCNAME}_SERVICE_HOST` 및 `{SVCNAME}_SERVICE_PORT` 변수를 지원하고,
-이때 서비스 이름은 대문자이고 대시는 밑줄로 변환된다.
+파드가 노드에서 실행될 때, kubelet은 각 활성화된 서비스에 대해 환경 변수 세트를 추가한다. 
+`{SVCNAME}_SERVICE_HOST` 및 `{SVCNAME}_SERVICE_PORT` 환경 변수가 추가되는데, 이 때 서비스 이름은 대문자로 변환되고 하이픈(`-`)은 언더스코어(`_`)로 변환된다. 또한 도커 엔진의 "_[레거시 컨테이너 연결](https://docs.docker.com/network/links/)_" 기능과 호환되는 변수([makeLinkVariables](https://github.com/kubernetes/kubernetes/blob/dd2d12f6dc0e654c15d5db57a5f9f6ba61192726/pkg/kubelet/envvars/envvars.go#L72) 참조)도 지원한다.


"서비스 이름은 대문자로 변환되고" -> "서비스 이름은 대문자이며" - no mention on 'conversation' (변환) from an original sentence: "Service name is upper-cased"

[원문]

When a Pod is run on a Node, the kubelet adds a set of environment variables for each active Service. It adds {SVCNAME}_SERVICE_HOST and {SVCNAME}_SERVICE_PORT variables, where the Service name is upper-cased and dashes are converted to underscores.

For example, the Service redis-master which exposes TCP port 6379 and has been allocated cluster IP address 10.0.0.11, produces the following environment variables:

REDIS_MASTER_SERVICE_HOST=10.0.0.11 REDIS_MASTER_SERVICE_PORT=6379 REDIS_MASTER_PORT=tcp://10.0.0.11:6379 REDIS_MASTER_PORT_6379_TCP=tcp://10.0.0.11:6379 REDIS_MASTER_PORT_6379_TCP_PROTO=tcp REDIS_MASTER_PORT_6379_TCP_PORT=6379 REDIS_MASTER_PORT_6379_TCP_ADDR=10.0.0.11

Service 이름은 보통 소문자와 하이픈으로 구성되는 반면에
환경 변수는 보통 대문자를 사용하고
하이픈은 사용 불가하므로 언더스코어를 사용하게 됩니다.

예시를 보면. the Service redis-master 에 대한 환경 변수들이
REDIS_MASTER_* 로 명명된 것을 볼 수 있습니다.

저는 원문의 "Service name is upper-cased" 를
"[대문자로 변환하다] 라는 뜻의 동사로 사용한 upper-case 의 수동태형" 으로 보고 이와 같이 번역했는데,
어떻게 생각하시나요? 😊

Translating passive tenses in English into active tenses in Korean is one of best practices - e.g., see #5 on https://blog.daum.net/rheesahn54/2021 . Then "서비스 이름은 대문자로 사용하며" would be also a good idea.

"파드가 노드에서 실행될 때, kubelet은 각 활성화된 서비스에 대해 환경 변수 세트를 추가한다.
{SVCNAME}_SERVICE_HOST 및 {SVCNAME}_SERVICE_PORT 환경 변수가 추가되는데, 이 때 서비스 이름은 대문자로, 하이픈(-)은 언더스코어(_)로 변환하여 사용한다."
로 변경하겠습니다. 😊

content/ko/docs/concepts/storage/persistent-volumes.md

content/ko/docs/contribute/review/reviewing-prs.md

ianychoi · 2022-03-05T09:29:07Z

/assign

jihoon-seo

@ianychoi 리뷰 감사합니다.
각 사항에 대해 의견을 남겼습니다.
확인 부탁드립니다. 😊

content/ko/docs/concepts/services-networking/service-traffic-policy.md

jihoon-seo · 2022-03-10T02:44:07Z

content/ko/docs/concepts/services-networking/service.md

-보다 간단한 `{SVCNAME}_SERVICE_HOST` 및 `{SVCNAME}_SERVICE_PORT` 변수를 지원하고,
-이때 서비스 이름은 대문자이고 대시는 밑줄로 변환된다.
+파드가 노드에서 실행될 때, kubelet은 각 활성화된 서비스에 대해 환경 변수 세트를 추가한다. 
+`{SVCNAME}_SERVICE_HOST` 및 `{SVCNAME}_SERVICE_PORT` 환경 변수가 추가되는데, 이 때 서비스 이름은 대문자로 변환되고 하이픈(`-`)은 언더스코어(`_`)로 변환된다. 또한 도커 엔진의 "_[레거시 컨테이너 연결](https://docs.docker.com/network/links/)_" 기능과 호환되는 변수([makeLinkVariables](https://github.com/kubernetes/kubernetes/blob/dd2d12f6dc0e654c15d5db57a5f9f6ba61192726/pkg/kubelet/envvars/envvars.go#L72) 참조)도 지원한다.


[원문]

When a Pod is run on a Node, the kubelet adds a set of environment variables for each active Service. It adds {SVCNAME}_SERVICE_HOST and {SVCNAME}_SERVICE_PORT variables, where the Service name is upper-cased and dashes are converted to underscores.

For example, the Service redis-master which exposes TCP port 6379 and has been allocated cluster IP address 10.0.0.11, produces the following environment variables:

REDIS_MASTER_SERVICE_HOST=10.0.0.11 REDIS_MASTER_SERVICE_PORT=6379 REDIS_MASTER_PORT=tcp://10.0.0.11:6379 REDIS_MASTER_PORT_6379_TCP=tcp://10.0.0.11:6379 REDIS_MASTER_PORT_6379_TCP_PROTO=tcp REDIS_MASTER_PORT_6379_TCP_PORT=6379 REDIS_MASTER_PORT_6379_TCP_ADDR=10.0.0.11

Service 이름은 보통 소문자와 하이픈으로 구성되는 반면에
환경 변수는 보통 대문자를 사용하고
하이픈은 사용 불가하므로 언더스코어를 사용하게 됩니다.

예시를 보면. the Service redis-master 에 대한 환경 변수들이
REDIS_MASTER_* 로 명명된 것을 볼 수 있습니다.

저는 원문의 "Service name is upper-cased" 를
"[대문자로 변환하다] 라는 뜻의 동사로 사용한 upper-case 의 수동태형" 으로 보고 이와 같이 번역했는데,
어떻게 생각하시나요? 😊

content/ko/docs/concepts/storage/persistent-volumes.md

content/ko/docs/contribute/review/reviewing-prs.md

ianychoi · 2022-03-18T12:29:10Z

Additionally commented thanks

jihoon-seo · 2022-03-21T06:04:25Z

@ianychoi 위와 같이 반영하고 squash까지 하였습니다. 😊

seokho-son · 2022-03-31T03:04:43Z

/lgtm
/approve

k8s-ci-robot · 2022-03-31T03:05:02Z

LGTM label has been added.

Git tree hash: 237be022e55a7f997963cc8f99429da43e019244

k8s-ci-robot · 2022-03-31T03:05:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/ko/OWNERS~~ [seokho-son]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2022

k8s-ci-robot requested review from gochist and jmyung February 16, 2022 03:08

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 16, 2022

ianychoi reviewed Mar 5, 2022

View reviewed changes

k8s-ci-robot assigned ianychoi Mar 5, 2022

jihoon-seo commented Mar 10, 2022

View reviewed changes

[ko] Update outdated files in dev-1.23-ko.2 M25-39

ce19161

jihoon-seo force-pushed the 220216_Outdated_M25-M39 branch from c9e8287 to ce19161 Compare March 21, 2022 06:02

k8s-ci-robot assigned seokho-son Mar 31, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022

k8s-ci-robot merged commit ffa959f into kubernetes:dev-1.23-ko.2 Mar 31, 2022

jihoon-seo deleted the 220216_Outdated_M25-M39 branch April 7, 2022 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ko] Update outdated files in `dev-1.23-ko.2` (M25-M39) #31761

[ko] Update outdated files in `dev-1.23-ko.2` (M25-M39) #31761

jihoon-seo commented Feb 16, 2022

netlify bot commented Feb 16, 2022 •

edited

Loading

ianychoi Mar 5, 2022

jihoon-seo Mar 10, 2022

ianychoi Mar 18, 2022

jihoon-seo Mar 21, 2022

ianychoi commented Mar 5, 2022

jihoon-seo left a comment

jihoon-seo Mar 10, 2022

ianychoi commented Mar 18, 2022

jihoon-seo commented Mar 21, 2022

seokho-son commented Mar 31, 2022

k8s-ci-robot commented Mar 31, 2022

k8s-ci-robot commented Mar 31, 2022

[ko] Update outdated files in dev-1.23-ko.2 (M25-M39) #31761

[ko] Update outdated files in dev-1.23-ko.2 (M25-M39) #31761

Conversation

jihoon-seo commented Feb 16, 2022

15 files to be modified

netlify bot commented Feb 16, 2022 • edited Loading

ianychoi Mar 5, 2022

Choose a reason for hiding this comment

jihoon-seo Mar 10, 2022

Choose a reason for hiding this comment

ianychoi Mar 18, 2022

Choose a reason for hiding this comment

jihoon-seo Mar 21, 2022

Choose a reason for hiding this comment

ianychoi commented Mar 5, 2022

jihoon-seo left a comment

Choose a reason for hiding this comment

jihoon-seo Mar 10, 2022

Choose a reason for hiding this comment

ianychoi commented Mar 18, 2022

jihoon-seo commented Mar 21, 2022

seokho-son commented Mar 31, 2022

k8s-ci-robot commented Mar 31, 2022

k8s-ci-robot commented Mar 31, 2022

[ko] Update outdated files in `dev-1.23-ko.2` (M25-M39) #31761

[ko] Update outdated files in `dev-1.23-ko.2` (M25-M39) #31761

netlify bot commented Feb 16, 2022 •

edited

Loading