Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add container image signature / verification docs #31611

Closed
wants to merge 1 commit into from
Closed

[WIP] Add container image signature / verification docs #31611

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 3, 2022 •
edited
Loading

Adding docs about how to verify the image signatures.

#31610 accidentally merged before so we have to review the whole "Container Images" section from a docs team perspective.

This is the placeholder PR for KEP kubernetes/enhancements#3031
Refers to kubernetes/release#2383
Closes #31420

cc @kubernetes/release-engineering
/hold

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2022
@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 02a1be9

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61fd05585b2c3a0007149f71

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 3, 2022
This was referenced Feb 3, 2022
Closed
Closed
sftim
sftim reviewed Feb 3, 2022
View reviewed changes
content/en/releases/download.md Outdated
@@ -68,7 +68,9 @@ container image name, for example
[`k8s.gcr.io/kube-apiserver-arm64:{{< param "fullversion" >}}`][0-arm64]. All
those derivations are signed in the same way as the multi-architecture manifest lists.

<!-- TODO: describe how to use the signed images -->
### Verifying Container Image Signatures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tip: this should be a signpost into a page within https://kubernetes.io/docs/tasks/

@jihoon-seo
Copy link
Member

Preview: https://deploy-preview-31611--kubernetes-io-vnext-staging.netlify.app/releases/download/#verifying-container-image-signatures

(Since Netlify bot comment is not properly updated 😅)

@saschagrunert
Add container image signing docs
02a1be9 
Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign annajung after the PR has been reviewed.
You can assign the PR to them by writing /assign @annajung in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Feb 4, 2022

/retitle [WIP] Add container image signature / verification docs

@k8s-ci-robot k8s-ci-robot changed the title [KEP-3031] Add container image signing docs [WIP] Add container image signature / verification docs Feb 4, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2022
@nate-double-u
Copy link
Contributor

/assign @chrisnegus

@saschagrunert saschagrunert mentioned this pull request Feb 25, 2022
Closed
@PushkarJ PushkarJ mentioned this pull request Mar 10, 2022
Merged
@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022 •
edited
Loading

@saschagrunert Still working on this? Maybe we should close this in favor of #32184 which is being actively worked on?

@saschagrunert
Copy link
Member Author

@saschagrunert Still working on this? Maybe we should close this in favor of #32184 which is being actively worked on?

Ah yeah makes sense, thank you for the hint!

@saschagrunert saschagrunert deleted the image-signing-docs branch March 25, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@chrisnegus chrisnegus

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@saschagrunert @jihoon-seo @k8s-ci-robot @sftim @nate-double-u @tengqm @chrisnegus