Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: use git.k8s.io to link to kubeadm repo #30229

Merged
merged 1 commit into from
Oct 26, 2021
Merged

kubeadm: use git.k8s.io to link to kubeadm repo #30229

merged 1 commit into from
Oct 26, 2021

Conversation

neolit123
Copy link
Member

With the kubeadm repository changing branch from
master -> main, use the "branchless" URL:
git.k8s.io/kubeadm
when linking to the HA guide.

xref kubernetes/kubeadm#2589

@neolit123
kubeadm: use git.k8s.io to link to kubeadm repo
0162445 
With the kubeadm repository changing branch from
master -> main, use the "branchless" URL:
  git.k8s.io/kubeadm
when linking to the HA guide.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 25, 2021
@neolit123
Copy link
Member Author

i did not find any other "master" references under /content/en.

/sig cluster-lifecycle
/kind cleanup
/cc @RA489 @SataQiu

@k8s-ci-robot k8s-ci-robot requested review from RA489 and SataQiu October 25, 2021 21:13
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 25, 2021
@neolit123
Copy link
Member Author

/assign @savitharaghunathan

@neolit123 neolit123 mentioned this pull request Oct 25, 2021
Closed
6 tasks
@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 0162445

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61771dad364dfa0008b1d652

😎 Browse the preview: https://deploy-preview-30229--kubernetes-io-main-staging.netlify.app

@RA489
Copy link

RA489 commented Oct 26, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 249763c30f9a48c1913479479c6d4dc0cd046581

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
sftim
sftim reviewed Oct 26, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit b750d98 into kubernetes:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@jimangel jimangel Awaiting requested review from jimangel

@RA489 RA489 Awaiting requested review from RA489

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@savitharaghunathan savitharaghunathan

@RA489 RA489

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neolit123 @RA489 @k8s-ci-robot @sftim @savitharaghunathan