Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new version of HA clusters guide. #2941

Closed
wants to merge 1 commit into from

Conversation

jszczepkowski
Copy link
Contributor

@jszczepkowski jszczepkowski commented Mar 21, 2017

Added a new version of HA clusters guide.


This change is Reviewable

Added a new version of HA clusters guide.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2017
@jszczepkowski
Copy link
Contributor Author

cc @kubernetes/sig-cluster-lifecycle-misc

@jszczepkowski
Copy link
Contributor Author

cc @fgrzadkowski

@pask81
Copy link

pask81 commented Mar 22, 2017

I was using the original guide as a reference to setup HA k8s masters on bare metal and while it was very outdated, it still could be considered a starting point for my use case.
I found your commit while looking for updates of the ha guide, but your guide is not useful for my use case.
Moreover, if I understood correctly, you changed even the basic idea of the old guide where master components were instantiated as static pods using yaml manifests, isn't anymore considered a valid choice?

@mikedanese
Copy link
Member

@pask81 master components in this guide are started as static pods. See the apiserver setup. Any other major differences?

@davidopp davidopp removed their request for review March 24, 2017 07:02
@davidopp davidopp removed their assignment Mar 24, 2017
@pask81
Copy link

pask81 commented Mar 24, 2017

@mikedanese the apiserver setup you linked belongs to the "old" guide that this commit renames as kubernetes.github.io/docs/admin/high-availability/index-obsolete.md. The "new" guide added by this commit doesn't have any refernece to pods or yaml files.

@polettix
Copy link

I like the idea of a "technology agnostic" architecture document describing the general ideas under the HA for different components, but it seems that the new version is tossing away important parts that are probably still "technology agnostic" and also useful for doing things (as opposed to figuring things out).

This seems to be reflected in the non-trivial change in the document goals; compare the new:

This document describes generic architecture of highly-available (HA) kubernetes clusters.

against the old:

This document describes how to build a high-availability (HA) Kubernetes cluster.

I may be missing the bigger picture about HA here, but it seems to me that both kind of documents have a place.

@chenopis
Copy link
Contributor

@jszczepkowski @polettix So how do we want to resolve this?

@jszczepkowski
Copy link
Contributor Author

Maybe we should keep both documents, the old one and the new one?

@chenopis
Copy link
Contributor

chenopis commented Jun 2, 2017

I'm fine w/ that so long as both docs are differentiated in both title and intro summary so that it's immediately clear to the reader which audience/scenario they are intended for.

@steveperry-53
Copy link
Contributor

@jszczepkowski I'll start a docs review now.

@steveperry-53 steveperry-53 self-requested a review October 2, 2017 22:01
@steveperry-53
Copy link
Contributor

@jszczepkowski In the right column, do you have an Allow edits by maintainers box? If so, could you check it. If it's already checked, uncheck and then recheck.

@steveperry-53
Copy link
Contributor

@jszczepkowski I have an edited doc ready to go. As soon as you check Allow edits by maintainers, I'll commit it for your review.

@steveperry-53
Copy link
Contributor

cc @fgrzadkowski @pask81 @mikedanese @polettix @chenopis

Note: I agree with the idea of keeping both documents.

@xiangpengzhao xiangpengzhao added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 19, 2017
@steveperry-53
Copy link
Contributor

We haven't heard from the author since June 2, 2017. Closing.
If you want to move forward with this, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants