Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nginx Ingress namespace #28445

Closed
wants to merge 1 commit into from
Closed

Fix Nginx Ingress namespace #28445

wants to merge 1 commit into from

Conversation

guoqiao
Copy link

@guoqiao guoqiao commented Jun 16, 2021

The correct namespace is ingress-nginx, not kube-system.

@guoqiao
Fix Nginx Ingress namespace
17c02a1 
The correct namespace is ingress-nginx, not kube-system.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tengqm after the PR has been reviewed.
You can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2021
@guoqiao
Copy link
Author

guoqiao commented Jun 16, 2021

I signed it

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2021
@jihoon-seo
Copy link
Member

Hello @guoqiao

The PR #28154 and #28355 are also suggesting this change.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@guoqiao
Copy link
Author

guoqiao commented Jun 16, 2021

Hi @jihoon-seo , thanks for letting me know, I will close PR then.

@guoqiao guoqiao closed this Jun 16, 2021
@netlify
Copy link

netlify bot commented Jun 16, 2021

✔️ Deploy Preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 17c02a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/60c9b65a54be190007e03066

😎 Browse the preview: https://deploy-preview-28445--kubernetes-io-master-staging.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guoqiao @k8s-ci-robot @jihoon-seo