Add docs for minReadySeconds in StatefulSet #27683

ravisantoshgudimetla · 2021-04-23T01:43:45Z

Add docs from minReadySeconds.

netlify · 2021-04-23T01:58:18Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ee7bd56

https://deploy-preview-27683--kubernetes-io-master-staging.netlify.app

kbhawkey · 2021-05-23T20:53:54Z

Hi @ravisantoshgudimetla .
Is this change for the 1.22 release? Docs for v1.22 features should use the dev-1.22 branch.
/cc @PI-Victor

ravisantoshgudimetla · 2021-05-23T21:44:08Z

Hi @ravisantoshgudimetla .
Is this change for the 1.22 release? Docs for v1.22 features should use the dev-1.22 branch.
/cc @PI-Victor

Yes @PI-Victor, updated the branch. Thank you.

PI-Victor · 2021-05-26T16:00:11Z

/assign @chrisnegus
/sig apps

soltysh

Don't forget to update https://github.com/kubernetes/website/blob/master/content/en/docs/reference/command-line-tools-reference/feature-gates.md

k8sio-netlify-preview-bot · 2021-06-15T17:08:22Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 2dff666

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60f9757d7dcd870007d59f9c

soltysh

/lgtm

k8s-ci-robot · 2021-06-15T19:12:44Z

LGTM label has been added.

Git tree hash: 4e07138c98b4e1a2cdd45e6c645bd90f01a8d91a

tengqm · 2021-06-16T09:33:37Z

content/en/docs/concepts/workloads/controllers/statefulset.md

@@ -228,6 +228,13 @@ and Ready or completely terminated prior to launching or terminating another
 Pod. This option only affects the behavior for scaling operations. Updates are not
 affected.

+#### Min Ready Seconds


I'd suggest we spell this as "Minimum ready seconds".

ravisantoshgudimetla · 2021-07-14T15:33:38Z

I don't need to update the featuregates as it was already covered by @tengqm in 372d34d

soltysh

/lgtm

k8s-ci-robot · 2021-07-14T15:43:17Z

LGTM label has been added.

Git tree hash: 50e90d95813a363b9c3fae38e1df69889601c7a4

sftim · 2021-07-16T08:45:34Z

/milestone 1.22

sftim

~~Do we also need to update https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ to mention StatefulSetMinReadySeconds?~~

sftim

Is this behind the StatefulSetMinReadySeconds feature gate? If so, let's also mention that in the StatefulSet concept page, and update https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

chrisnegus · 2021-07-16T16:10:08Z

Is this behind the StatefulSetMinReadySeconds feature gate? If so, let's also mention that in the StatefulSet concept page, and update https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

I'm 1.22 release docs shadow for this PR. It looks like the changes for this feature to the dev-1.22 feature-gates page have already been merged. This PR seems to cover the StatefulSet concept page you asked about. @sftim is there more that you think needs to be done or is this ready to be merged?

PI-Victor · 2021-07-21T14:25:31Z

based on Chris' comment i'd like to merge this, anything to else needs to be added?

sftim

I think this feedback is right - not sure. If I'm wrong please comment and then dismiss this review.

sftim · 2021-07-21T14:31:27Z

content/en/docs/concepts/workloads/controllers/statefulset.md

+#### Minimum Ready Seconds
+
+{{< feature-state for_k8s_version="v1.22" state="alpha" >}}
+


Let's explain that this field only works if you enable the StatefulSetMinReadySeconds feature gate.

Sure, I added it here. PTAL.

tengqm · 2021-07-22T04:58:20Z

content/en/docs/concepts/workloads/controllers/statefulset.md

+This defaults to 0 (the Pod will be considered available as soon as it is ready). To learn more about when
+a Pod is considered ready, see [Container Probes](/docs/concepts/workloads/pods/pod-lifecycle/#container-probes).
+
+Please note that this field only works if you enable the `StatefulSetMinReadySeconds` featuregate


Suggested change

Please note that this field only works if you enable the `StatefulSetMinReadySeconds` featuregate

Please note that this field only works if you enable the `StatefulSetMinReadySeconds` feature gate.

tengqm · 2021-07-23T01:30:34Z

All feedbacks addressed. Good to go.
/lgtm
/approve

k8s-ci-robot · 2021-07-23T01:30:41Z

LGTM label has been added.

Git tree hash: e54afbee4344820f21013487217732c57aaf0bbe

k8s-ci-robot · 2021-07-23T01:30:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2021

k8s-ci-robot requested review from enisoc and smarterclayton April 23, 2021 01:44

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 23, 2021

k8s-ci-robot requested a review from PI-Victor May 23, 2021 20:53

ravisantoshgudimetla changed the base branch from master to dev-1.22 May 23, 2021 21:43

k8s-ci-robot assigned chrisnegus May 26, 2021

k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label May 26, 2021

soltysh suggested changes Jun 15, 2021

View reviewed changes

ravisantoshgudimetla force-pushed the patch-8 branch from ee7bd56 to 8eafd71 Compare June 15, 2021 17:08

ravisantoshgudimetla changed the title ~~[wip] Add docs for minReadySeconds in StatefulSet~~ Add docs for minReadySeconds in StatefulSet Jun 15, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2021

ravisantoshgudimetla force-pushed the patch-8 branch from 8eafd71 to 8d6019d Compare June 15, 2021 17:22

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021

soltysh approved these changes Jun 15, 2021

View reviewed changes

k8s-ci-robot assigned soltysh Jun 15, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021

tengqm reviewed Jun 16, 2021

View reviewed changes

ravisantoshgudimetla force-pushed the patch-8 branch from 8d6019d to 0159ef9 Compare June 21, 2021 15:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2021

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2021

ravisantoshgudimetla force-pushed the patch-8 branch 2 times, most recently from 61b7599 to 80b3683 Compare July 14, 2021 15:32

soltysh approved these changes Jul 14, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2021

k8s-ci-robot added this to the 1.22 milestone Jul 16, 2021

sftim reviewed Jul 16, 2021

View reviewed changes

sftim requested changes Jul 21, 2021

View reviewed changes

ravisantoshgudimetla force-pushed the patch-8 branch from 80b3683 to 9cc7f3c Compare July 21, 2021 16:16

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2021

tengqm reviewed Jul 22, 2021

View reviewed changes

Add minReadySeconds to statefulsets

2dff666

ravisantoshgudimetla force-pushed the patch-8 branch from 9cc7f3c to 2dff666 Compare July 22, 2021 13:41

k8s-ci-robot assigned tengqm Jul 23, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021

k8s-ci-robot merged commit 794a8ff into kubernetes:dev-1.22 Jul 23, 2021

sftim mentioned this pull request Aug 2, 2021

Improve StatefulSet .minReadySeconds docs #29193

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add docs for minReadySeconds in StatefulSet #27683

Add docs for minReadySeconds in StatefulSet #27683

ravisantoshgudimetla commented Apr 23, 2021

netlify bot commented Apr 23, 2021

kbhawkey commented May 23, 2021

ravisantoshgudimetla commented May 23, 2021

PI-Victor commented May 26, 2021

soltysh left a comment

k8sio-netlify-preview-bot commented Jun 15, 2021 •

edited by netlify bot

Loading

soltysh left a comment

k8s-ci-robot commented Jun 15, 2021

tengqm Jun 16, 2021

ravisantoshgudimetla Jun 21, 2021

ravisantoshgudimetla commented Jul 14, 2021

soltysh left a comment

k8s-ci-robot commented Jul 14, 2021

sftim commented Jul 16, 2021

sftim left a comment •

edited

Loading

sftim left a comment

chrisnegus commented Jul 16, 2021

PI-Victor commented Jul 21, 2021

sftim left a comment

sftim Jul 21, 2021

ravisantoshgudimetla Jul 21, 2021

tengqm Jul 22, 2021

ravisantoshgudimetla Jul 22, 2021

tengqm commented Jul 23, 2021

k8s-ci-robot commented Jul 23, 2021

k8s-ci-robot commented Jul 23, 2021

		#### Minimum Ready Seconds

		{{< feature-state for_k8s_version="v1.22" state="alpha" >}}

	Please note that this field only works if you enable the `StatefulSetMinReadySeconds` featuregate
	Please note that this field only works if you enable the `StatefulSetMinReadySeconds` feature gate.

Add docs for minReadySeconds in StatefulSet #27683

Add docs for minReadySeconds in StatefulSet #27683

Conversation

ravisantoshgudimetla commented Apr 23, 2021

netlify bot commented Apr 23, 2021

kbhawkey commented May 23, 2021

ravisantoshgudimetla commented May 23, 2021

PI-Victor commented May 26, 2021

soltysh left a comment

Choose a reason for hiding this comment

k8sio-netlify-preview-bot commented Jun 15, 2021 • edited by netlify bot Loading

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 15, 2021

tengqm Jun 16, 2021

Choose a reason for hiding this comment

ravisantoshgudimetla Jun 21, 2021

Choose a reason for hiding this comment

ravisantoshgudimetla commented Jul 14, 2021

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 14, 2021

sftim commented Jul 16, 2021

sftim left a comment • edited Loading

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

chrisnegus commented Jul 16, 2021

PI-Victor commented Jul 21, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim Jul 21, 2021

Choose a reason for hiding this comment

ravisantoshgudimetla Jul 21, 2021

Choose a reason for hiding this comment

tengqm Jul 22, 2021

Choose a reason for hiding this comment

ravisantoshgudimetla Jul 22, 2021

Choose a reason for hiding this comment

tengqm commented Jul 23, 2021

k8s-ci-robot commented Jul 23, 2021

k8s-ci-robot commented Jul 23, 2021

k8sio-netlify-preview-bot commented Jun 15, 2021 •

edited by netlify bot

Loading

sftim left a comment •

edited

Loading