Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated user guide for kubectl taint by adding NoExecute. #2744

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Updated user guide for kubectl taint by adding NoExecute. #2744

merged 1 commit into from
Mar 21, 2017

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Mar 9, 2017 •
edited by k8s-reviewable
Loading

Fixed part of #2737

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2017
@gyliu513 gyliu513 mentioned this pull request Mar 12, 2017
Merged
cmluciano
cmluciano reviewed Mar 13, 2017
View reviewed changes
Copy link
Contributor

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aveshagarwal
Copy link
Member

LGTM.

FYI: @mburke5678

@kevin-wangzefeng
Copy link
Member

LGTM.

You may rebase to the latest master since it's prompting "This branch is out-of-date with the base branch".

@gyliu513
Copy link
Contributor Author

This is target for 1.6, can we have this merged soon? @aveshagarwal @kevin-wangzefeng @cmluciano

@davidopp davidopp changed the base branch from master to release-1.6 March 18, 2017 07:56
@davidopp davidopp added this to the 1.6 milestone Mar 18, 2017
@davidopp
Copy link
Member

LGTM

@gyliu513
Copy link
Contributor Author

/cc @kubernetes/sig-docs-maintainers

@mburke5678
Copy link
Contributor

LGTM

@chenopis chenopis merged commit ff7b67d into kubernetes:release-1.6 Mar 21, 2017
@chenopis chenopis self-assigned this Mar 21, 2017
@gyliu513 gyliu513 deleted the kubectl-taint branch March 21, 2017 23:43
@mengqiy
Copy link
Member

mengqiy commented Mar 21, 2017

@gyliu513 @chenopis There is no need to manually update the doc here. These files are all generated (see the bottom of this file)
We will run scripts to update the imported doc, like kubectl help message.

https://github.com/kubernetes/kubernetes.github.io/blob/master/update-imported-docs.sh

For new reference docs, @pwittrock has script in https://github.com/kubernetes-incubator/reference-docs to update the new style doc.

FYI, we are not maintaining the old docs.

cc: @devin-donnelly

@gyliu513
Copy link
Contributor Author

Good to know, thanks @ymqytw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano cmluciano left review comments

Assignees

@chenopis chenopis

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
9 participants
@gyliu513 @aveshagarwal @kevin-wangzefeng @davidopp @mburke5678 @mengqiy @cmluciano @k8s-ci-robot @chenopis