Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VolumeSubpath is GA since 1.10 #26607

Merged
merged 1 commit into from
Feb 19, 2021
Merged

VolumeSubpath is GA since 1.10 #26607

merged 1 commit into from
Feb 19, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Feb 18, 2021

kubernetes/kubernetes#60813

Correct a feature gate version. The feature gate VolumeSubpath is GA since 1.10 for CVEs.

Fixed versions:

  • Fixed in v1.7.14 by kubernetes#61047
  • Fixed in v1.8.9 by kubernetes#61046
  • Fixed in v1.9.4 by kubernetes#61045
  • Fixed in master by kubernetes#61044 (included in v1.10.0-beta.3, will be in v1.10.0)

It can be disabled even it is GA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2021
@netlify
Copy link

netlify bot commented Feb 18, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 037e767

https://deploy-preview-26607--kubernetes-io-master-staging.netlify.app

@pacoxu pacoxu mentioned this pull request Feb 18, 2021
Closed
@sftim
Copy link
Contributor

sftim commented Feb 18, 2021

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Feb 18, 2021
@pacoxu
Copy link
Member Author

pacoxu commented Feb 18, 2021

BTW.

If VolumeSubpath is disabled， the subpathEnvExp also will not work（VolumeSubpathEnvExpasion）.

VolumeSubpathEnvExpasion is locked to true now.

@sftim
Copy link
Contributor

sftim commented Feb 18, 2021

@kubernetes/sig-storage-pr-reviews please confirm LGTM, then this'll be good to approve.

@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-26607--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features

👋 @pacoxu .
This change seems fine. Waiting for approval from Sig Storage.
Are there alpha and beta versions for this feature?

@pacoxu
Copy link
Member Author

pacoxu commented Feb 18, 2021

Page preview:

https://deploy-preview-26607--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features

👋 @pacoxu .

This change seems fine. Waiting for approval from Sig Storage.

Are there alpha and beta versions for this feature?

No alpha or beta. And this ga feature is not locked to true since then. According to comments， it will not be removed as well 😄.

msau42
msau42 reviewed Feb 19, 2021
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -351,7 +351,7 @@ different Kubernetes components.
| `VolumeScheduling` | `false` | Alpha | 1.9 | 1.9 |
| `VolumeScheduling` | `true` | Beta | 1.10 | 1.12 |
| `VolumeScheduling` | `true` | GA | 1.13 | - |
| `VolumeSubpath` | `true` | GA | 1.13 | - |
| `VolumeSubpath` | `true` | GA | 1.10 | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's weird because the feature has existed since 1.3, but we only added the feature gate for it as part of the CVE fix. It also means that the feature gate exists back in 1.7 patch releases.

If the intention of this page is to document when the actual feature gates were introduced, then I guess 1.10 works.

Copy link
Member Author

@pacoxu pacoxu Feb 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a special case.

To be more accurate.

  • volume subpath feature is since 1.3
  • VolumeSubpath feature-gate is since 1.10 and backported to 1.7-1.9 for CVEs fix.
  • VolumeSubpathEnvExpansion feature-gate depends on VolumeSubpath feature-gate: if VolumeSubpath is disabled, VolumeSubpathEnvExpansion will not work as well.

@msau42
Copy link
Member

msau42 commented Feb 19, 2021

/lgtm
from tech

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0de10fe9d8be75f589569161442f8ba9d8f2a156

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit bbf5e90 into kubernetes:master Feb 19, 2021
@pacoxu pacoxu deleted the patch-3 branch June 26, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pacoxu @sftim @kbhawkey @msau42 @k8s-ci-robot