-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taint based eviction promoted to GA in 1.18 #19302
Taint based eviction promoted to GA in 1.18 #19302
Conversation
/hold |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 10378d0 https://deploy-preview-19302--kubernetes-io-master-staging.netlify.com |
Hi @ingvagabund This repository has a live master branch (and does not usually cherry-pick). I think you should edit this PR to target the branch dev-1.18. /sig scheduling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4888745
to
10378d0
Compare
10378d0
to
0de472c
Compare
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 37912a1 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5e663b5e9120a50009b04841 |
@sftim thanks!!! |
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
0de472c
to
51ed2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This is just waiting for kubernetes/kubernetes#88152 and kubernetes/kubernetes#87487 to merge
51ed2bd
to
9c6af49
Compare
/hold cancel |
@ingvagabund A reminder Re:
The 1.18 release team will cover it, so you don't need to manually cherry-pick it. |
/milestone v1.18 |
@ahg-g: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
👋 Please rebase this PR on Feel free to /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more feedback on the text @ingvagabund
The taints are automatically added by the NodeController (or kubelet) and the normal | ||
logic for evicting pods from nodes based on the Ready NodeCondition is disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this also accurate
The taints are automatically added by the NodeController (or kubelet) and the normal | |
logic for evicting pods from nodes based on the Ready NodeCondition is disabled. | |
When the node controller or the kubelet observe problems on a node, they add taints to the | |
relevant Node object. If the fault condition returns to normal the kubelet or node | |
controller can remove the relevant taint(s). The kubelet reports problems that affect | |
its ability to run Pods whereas the node controller monitors whether the kubelet | |
itself is healthy. |
?
I wouldn't mention “the normal logic for evicting pods from nodes based on the Ready NodeCondition is disabled” if there's no way to make use of that logic in v1.18. If there is a way to make use of that formerly-normal logic, tell readers how to learn about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be careful here to properly distinguish when a taint has NoSchedule
effect and when it has NoExecute
. I have integrated the first two sentences. The last one expresses a general statement saying "a node is tainted based on a condition" which can have both effects interchangeable.
9c6af49
to
37912a1
Compare
Done
/hold cancel |
@sftim updated, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping, is there any more feedback for this?
/lgtm
from the scheduling side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown & page style looks good to me
@sftim thanks, can you /approve this? |
@damemi I'm not on the docs release team |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Taint based eviction as described in https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/#taint-based-evictions is about to be GA'ed in 1.18. Updating the docs appropriately.
Fixes: kubernetes/kubernetes#87429
Will cherry-pick to 1.18 until this one is reviewed or before Friday.