Windows documentation updates for 1.14 #12929

craiglpeters · 2019-03-01T19:52:15Z

/milestone 1.14
/hold
/sig windows

k8sio-netlify-preview-bot · 2019-03-01T19:52:21Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 1591c84

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5c90f4ae009bb80008fa5889

neolit123

not sure we should link to the source gdoc file and tracking issue. leaning towards not doing that and only saying "updated in 1.14".
/assign @jimangel

michmike · 2019-03-01T23:57:02Z

@craiglpeters do you want to merge this in now, or is this PR as a placeholder for all the updates we want to make?

jimangel · 2019-03-10T15:28:00Z

@craiglpeters - I know we chatted on slack, but a friendly reminder about the Monday EOD docs deadline to be ready to review.

I'm still on board with the plan to allow this doc represent the "bulk" of the needed info (maybe not all nits) and another PR ready to be merged post-release against master to address minor bits (as discussed: #12426 (comment)).

Let me know if you have any questions!

@neolit123 agreed, this won't merge with just a google doc link. I believe this was opened as a placeholder. See above for more context.

@michmike see above for context.

michmike · 2019-03-13T03:29:14Z

fixes #12426

updating a few sections like roadmap, services, troubleshooting/filing tickets

michmike · 2019-03-19T05:33:33Z

everyone, and @jimangel in particular: can we please LGTM+approve this PR so that we can merge it in? we can create additional PRs on additional content

i am also interested if there is a staging netlify site set up where i can view the 1.14 docs as they will go live so that we can see all our PRs that are merged in unison.

michmike · 2019-03-19T05:34:20Z

/lgtm
/approve

cody-clark · 2019-03-19T05:47:55Z

Ah, is there any way you can resolve the merge conflicts, @michmike? I'm happy to approve it

kbhawkey · 2019-03-19T12:21:46Z

content/en/docs/getting-started-guides/windows/_index.md

-    **Windows _container hosts_ are not able to access the IP of services scheduled on them due to current platform limitations of the Windows networking stack. Only Windows _pods_ are able to access service IPs.
-    {{< /note >}}
+
+{{< note >}}


If you want the page to look like the other content pages, you can add a template type attribute in the front matter:
content_template: templates/concept. With this template, you are required to include an overview and then a body. See another page under concepts for an example. This template will provide an internal toc at the top, based upon the main headers in the doc. May help navigation of the page.

Or, I see that other pages in setup do not set a template type and instead include the toc shortcode at the top,
{{< toc >}}. See content/en/docs/setup/node-conformance.md as an example.

nit: the tables could be converted to Markdown

let us merge this PR and i will create a new one to do these changes. very helpful hints @kbhawkey

@kbhawkey i fixed this in another PR and will ping you there :)

michmike · 2019-03-19T13:56:17Z

Ah, is there any way you can resolve the merge conflicts, @michmike? I'm happy to approve it

done!

michmike · 2019-03-19T14:10:04Z

/lgtm
/approve

michmike · 2019-03-19T15:29:54Z

/assign @jimangel

cody-clark · 2019-03-19T16:30:35Z

Thanks, @michmike!

Preview: https://5c90f4ae009bb80008fa5889--kubernetes-io-vnext-staging.netlify.com/docs/getting-started-guides/windows/

/approve

k8s-ci-robot · 2019-03-19T16:30:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [cody-clark]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cody-clark

/hold cancel

* Official documentation on Poseidon/Firmament, a new multi-scheduler support for K8S. (#11752) * Added documentation about Poseidon-Firmament scheduler * Fixed some style issues. * Udpated the document as per the review comments. * Fixed some typos and updated the document * Updated the document as per the review comments. * Document timeout attribute for kms-plugin. (#12158) See 72540. * Official documentation on Poseidon/Firmament, a new multi-scheduler (#12343) * Removed the old version of the Poseidon documentation. Incorrect location. * Official documentation on Poseidon/Firmament, a new multi-scheduler support for K8S (#12069) * Official documentation on Poseidon/Firmament, a new multi-scheduler support for K8S. (#11752) * Added documentation about Poseidon-Firmament scheduler * Fixed some style issues. * Udpated the document as per the review comments. * Fixed some typos and updated the document * Updated the document as per the review comments. * Updated the document as per review comments. Added config details. * Updated the document as per the latest review comments. Fixed nits * Made changes as per latest suggestions. * Some more changes added. * Updated as per suggestions. * Changed the release process section. * SIG Docs edits Small edits to match style guidelines. * add plus to feature state * capitalization * revert feature state shortcode since this is a Kubernetes extension, not a direct feature, it shouldn't use the regular feature state tagging. (cherry picked from commit 7730c15) * Remove initializers from doc. It will be removed in 1.14 (#12331) * kubeadm: Document CRI auto detection functionality (#12462) Signed-off-by: Rostislav M. Georgiev <[email protected]> * Minor doc change for GAing Pod DNS Config (#12514) * Graduate ExpandInUsePersistentVolumes feature to beta (#10574) * Rename 2018-11-07-grpc-load-balancing-with-linkerd.md.md file (#12594) * Add dynamic percentage of node scoring to user docs (#12235) * Add dynamic percentage of node scoring to user docs * addressed review comments * delete special symbol (#12445) * Update documentation for VolumeSubpathEnvExpansion (#11843) * Update documentation for VolumeSubpathEnvExpansion * Address comments - improve descriptions * Graduate Pod Priority and Preemption to GA (#12428) * Added Instana links to the documentation (#12977) * Added link to the Instana Kubernetes integration * Added Instana link for services section Added Instana and a link to the Kubernetes integration to the analytics services section and broadened the scope to APM, monitoring and analytics. * Oxford comma /flex * More Oxford commas, because they matter * Update kubectl plugins to stable (#12847) * documentation for CSI topology beta (#12889) * Document changes to default RBAC discovery ClusterRole(Binding)s (#12888) * Document changes to default RBAC discovery ClusterRole(Binding)s Documentation for kubernetes/enhancements#789 and kubernetes/kubernetes#73807 * documentation review feedback * CSI raw block to beta (#12931) * Change incorrect string raw to block (#12926) Fixes #12925 * Update documentation on node OS/arch labels (#12976) These labels have been promoted to GA: kubernetes/enhancements#793 * local pv GA doc updates (#12915) * Publish CRD OpenAPI Documentation (#12910) * add documentation for CustomResourcePublishOpenAPI * address comments fix links, ordered lists, style and typo * kubeadm: add document for upgrading from 1.13 to 1.14 (single CP and HA) (#13189) * kubeadm: add document for upgrading from 1.13 to 1.14 - remove doc for upgrading 1.10 -> 1.11 * kubeadm: apply amends to upgrade-1.14 doc * kubeadm: apply amends to upgrade-1.14 doc (part2) * kubeadm: apply amends to upgrade-1.14 doc (part3) * kubeadm: add note about "upgrade node experimental-control-plane" + add comment about `upgrade plan` * kubeadm: add missing "You should see output similar to this" * fix bullet indentation (#13214) * mark PodReadinessGate GA (#12800) * Update RuntimeClass documentation for beta (#13043) * Update RuntimeClass documentation for beta * Update feature gate & add upgrade section * formatting fixes * Highlight upgrade action required * Address feedback * CSI ephemeral volume alpha documentation (#10934) * update kubectl documentation (#12867) * update kubectl documentation * add document for Secret/ConfigMap generators * replace `kubectl create -f` by `kubectl apply -f` * Add page for kustomization support in kubectl * fix spelling errors and address comments * Documentation for Windows GMSA feature (#12936) * Documentation for Windows GMSA feature Signed-off-by: Deep Debroy <[email protected]> * Enhancements to GMSA docs Signed-off-by: Deep Debroy <[email protected]> * Fix links Signed-off-by: Deep Debroy <[email protected]> * Fix GMSA link Signed-off-by: Deep Debroy <[email protected]> * Add GMSA feature flag in feature flag list Signed-off-by: Deep Debroy <[email protected]> * Relocate GMSA to container configuration Signed-off-by: Deep Debroy <[email protected]> * Add example for container spec Signed-off-by: Deep Debroy <[email protected]> * Remove changes in Windows index Signed-off-by: Deep Debroy <[email protected]> * Update configure-gmsa.md * Update configure-gmsa.md * Update configure-gmsa.md * Update configure-gmsa.md * Rearrange the steps into two sections and other edits Signed-off-by: Deep Debroy <[email protected]> * Fix links Signed-off-by: Deep Debroy <[email protected]> * Add reference to script to generate GMSA YAMLs Signed-off-by: Deep Debroy <[email protected]> * Some more clarifications for GMSA Signed-off-by: Deep Debroy <[email protected]> * HugePages graduated to GA (#13004) * HugePages graduated to GA * fixing nit for build * Docs for node PID limiting (kubernetes/kubernetes#73651) (#12932) * kubeadm: update the reference documentation for 1.14 (#12911) * kubeadm: update list of generated files for 1.14 NOTE: PLACEHOLDERS! these files are generated by SIG Docs each release, but we need them to pass the k/website PR CI. - add join_phase* (new sub phases of join) - add init_phase_upload-certs.md (new upload certs phase for init) - remove alpha-preflight (now both init and join have this) * kubeadm: update reference docs includes for 1.14 - remove includes from alpha.md - add upload-certs to init-phase.md - add join-phase.md and it's phases * kubeadm: update the editorial content of join and init - cleanup master->control-plane node - add some notes about phases and join - remove table about pre-pulling images - remove outdated info about self-hosting * kubeadm: update target release for v1alpha3 removal 1.14 -> 1.15 * kubeadm: copy edits for 1.14 reference docs (part1) * kubeadm: use "shell" for code blocks * kubeadm: update the 1.14 HA guide (#13191) * kubeadm: update the 1.14 HA guide * kubeadm: try to fix note/caution indent in HA page * kubeadm: fix missing sudo and minor amends in HA doc * kubeadm: apply latest amends to the HA doc for 1.14 * fixed a few missed merge conflicts * Admission Webhook new features doc (#12938) - kubernetes/kubernetes#74998 - kubernetes/kubernetes#74477 - kubernetes/kubernetes#74562 * Clarifications and fixes in GMSA doc (#13226) * Clarifications and fixes in GMSA doc Signed-off-by: Deep Debroy <[email protected]> * Update configure-gmsa.md * Reformat to align headings and pre-reqs better Signed-off-by: Deep Debroy <[email protected]> * Reformat to align headings and pre-reqs better Signed-off-by: Deep Debroy <[email protected]> * Reformat to fix bullets Signed-off-by: Deep Debroy <[email protected]> * Reword application of sample gmsa Signed-off-by: Deep Debroy <[email protected]> * Update configure-gmsa.md * Address feedback to use active voice Signed-off-by: Deep Debroy <[email protected]> * Address feedback to use active voice Signed-off-by: Deep Debroy <[email protected]> * RunAsGroup documentation for Progressing this to Beta (#12297) * start serverside-apply documentation (#13077) * start serverside-apply documentation * add more concept info on server side apply * Update api concepts * Update api-concepts.md * fix style issues * Document CSI update (#12928) * Document CSI update * Finish CSI documentation Also fix mistake with ExpandInUsePersistentVolumes documented as beta * Overall docs for CSI Migration feature (#12935) * Placeholder docs for CSI Migration feature Signed-off-by: Deep Debroy <[email protected]> * Address CR comments and update feature gates Signed-off-by: Deep Debroy <[email protected]> * Add mappings for CSI plugins Signed-off-by: Deep Debroy <[email protected]> * Add sections for AWS and GCE PD migration Signed-off-by: Deep Debroy <[email protected]> * Add docs for Cinder and CSI Migration info Signed-off-by: Deep Debroy <[email protected]> * Clarify scope to volumes with file system Signed-off-by: Deep Debroy <[email protected]> * Change the format of EBS and Cinder CSI Migration sections to follow the GCE template Signed-off-by: Deep Debroy <[email protected]> * Windows documentation updates for 1.14 (#12929) * Updated the note to indicate doc work for 1.14 * first attempt at md export from gdoc * simplifyig * big attempt * moving DRAFT windows content to PR for review * moving content to PR in markdown for review * updated note tags * Delete windows-contributing.md deleting this file as it is already ported to the github contributor guide * fixed formatting in intro and cluster setup guide * updating formatting for running containers guide * rejiggered end of troubleshooting * fixed minor typos * Clarified the windows binary download step * Update _index.md making updates based on feedback * Update _index.md updating ovn-kubernetes docs * Update _index.md * Update _index.md * updating relative docs links updating all the links to be relative links to /docs * Update _index.md * Update _index.md updates for windows services and ovn-kubernetes * formatted for correct step numbering * fix typos * Update _index.md updates for flannel PR in troubleshooting * Update _index.md * Update _index.md updating a few sections like roadmap, services, troubleshooting/filing tickets * Update _index.md * Update _index.md * Update _index.md * Fixed a few whitespace issues * Update _index.md * Update _index.md * Update _index.md * add section on upgrading CoreDNS (#12909) * documentation for kubelet resource metrics endpoint (#12934) * windows docs updates for 1.14 (#13279) * Delete sample-l2bridge-wincni-config.json this file is not used anywhere * Update _index.md * Update _index.md * Update _index.md * Update _index.md * Update _index.md * Rename content/en/docs/getting-started-guides/windows/_index.md to content/en/docs/setup/windows/_index.md moving to new location * Delete flannel-master-kubectl-get-ds.png * Delete flannel-master-kubeclt-get-pods.png * Delete windows-docker-error.png * Add files via upload * Rename _index.md to add-windows-nodes.md * Create _index.md * Update _index.md * Update add-windows-nodes.md * Update add-windows-nodes.md * Create user-guide-windows-nodes.md * Create user-guide-windows-containers.md * Update and rename add-windows-nodes.md to intro-windows-nodes.md * Update user-guide-windows-containers.md * Rename intro-windows-nodes.md to intro-windows-in-kubernetes.md * Update user-guide-windows-nodes.md * Update user-guide-windows-containers.md * Update user-guide-windows-containers.md * Update user-guide-windows-nodes.md * Update user-guide-windows-containers.md * Update _index.md * Update intro-windows-in-kubernetes.md * Update intro-windows-in-kubernetes.md fixing the pause image * Update intro-windows-in-kubernetes.md changing tables from html to MD * Update user-guide-windows-nodes.md converting tables from HTML to MD * Update intro-windows-in-kubernetes.md * Update user-guide-windows-nodes.md * Update user-guide-windows-nodes.md * Update user-guide-windows-nodes.md updating the numbering , even though it messes up the notes a little bit. Jim will file a ticket to follow up * Update user-guide-windows-nodes.md * update to windows docs for 1.14 (#13322) * Update intro-windows-in-kubernetes.md * Update intro-windows-in-kubernetes.md * Update intro-windows-in-kubernetes.md * Update intro-windows-in-kubernetes.md * Update intro-windows-in-kubernetes.md * Update user-guide-windows-containers.md * Update user-guide-windows-nodes.md * Update intro-windows-in-kubernetes.md (#13344) * server side apply followup (#13321) * change some parts of serverside apply docs in response to comments * fix typos and wording * Update config.toml (#13365)

Updated the note to indicate doc work for 1.14

264f4ed

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2019

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 1, 2019

k8s-ci-robot requested review from errordeveloper and jimangel March 1, 2019 19:52

This was referenced Mar 1, 2019

Docs for Running Windows Containers in Kubernetes #12426

Closed

Support Windows Server Containers for K8s kubernetes/enhancements#116

Closed

k8s-ci-robot assigned jimangel Mar 1, 2019

neolit123 reviewed Mar 1, 2019

View reviewed changes

zacharysarah added this to the 1.14 milestone Mar 7, 2019

first attempt at md export from gdoc

aef823f

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2019

simplifyig

0e14aa5

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 12, 2019

big attempt

425a934

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2019

craiglpeters added 3 commits March 12, 2019 17:42

moving DRAFT windows content to PR for review

23508d5

moving content to PR in markdown for review

5ebda61

updated note tags

a449d5e

michmike added 3 commits March 18, 2019 16:16

Update _index.md

f4210e6

updating a few sections like roadmap, services, troubleshooting/filing tickets

Update _index.md

cd82c1f

Update _index.md

81d5ac7

zacharysarah mentioned this pull request Mar 18, 2019

Remove orphaned content #13262

Closed

michmike and others added 5 commits March 18, 2019 23:39

Update _index.md

f18f1a8

Fixed a few whitespace issues

b24c692

Update _index.md

418fd43

Update _index.md

814f384

Update _index.md

8376485

k8s-ci-robot assigned michmike Mar 19, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2019

kbhawkey reviewed Mar 19, 2019

View reviewed changes

Merge branch 'dev-1.14' into dev-1.14

1591c84

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2019

cody-clark approved these changes Mar 19, 2019

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2019

k8s-ci-robot merged commit f1ffe72 into kubernetes:dev-1.14 Mar 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows documentation updates for 1.14 #12929

Windows documentation updates for 1.14 #12929

craiglpeters commented Mar 1, 2019

k8sio-netlify-preview-bot commented Mar 1, 2019 •

edited

Loading

neolit123 left a comment

michmike commented Mar 1, 2019

jimangel commented Mar 10, 2019

michmike commented Mar 13, 2019

michmike commented Mar 19, 2019

michmike commented Mar 19, 2019

cody-clark commented Mar 19, 2019

kbhawkey Mar 19, 2019

michmike Mar 19, 2019

michmike Mar 19, 2019

michmike commented Mar 19, 2019

michmike commented Mar 19, 2019

michmike commented Mar 19, 2019

cody-clark commented Mar 19, 2019

k8s-ci-robot commented Mar 19, 2019

cody-clark left a comment

Windows documentation updates for 1.14 #12929

Windows documentation updates for 1.14 #12929

Conversation

craiglpeters commented Mar 1, 2019

k8sio-netlify-preview-bot commented Mar 1, 2019 • edited Loading

neolit123 left a comment

Choose a reason for hiding this comment

michmike commented Mar 1, 2019

jimangel commented Mar 10, 2019

michmike commented Mar 13, 2019

michmike commented Mar 19, 2019

michmike commented Mar 19, 2019

cody-clark commented Mar 19, 2019

kbhawkey Mar 19, 2019

Choose a reason for hiding this comment

michmike Mar 19, 2019

Choose a reason for hiding this comment

michmike Mar 19, 2019

Choose a reason for hiding this comment

michmike commented Mar 19, 2019

michmike commented Mar 19, 2019

michmike commented Mar 19, 2019

cody-clark commented Mar 19, 2019

k8s-ci-robot commented Mar 19, 2019

cody-clark left a comment

Choose a reason for hiding this comment

k8sio-netlify-preview-bot commented Mar 1, 2019 •

edited

Loading