WIP: Windows doc set for v1.13 stable #10875
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit cc29ef9 https://deploy-preview-10875--kubernetes-io-master-staging.netlify.com |
|
Deploy preview for kubernetes-io-master-staging failed. Built with commit cddd543 https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bdcd2ac4ed62f495ba48fbe |
PatrickLang
force-pushed
the
windows-v1.13
branch
from
cc29ef9
to
cddd543
Compare
PatrickLang
force-pushed
the
windows-v1.13
branch
from
edae4b2
to
e984068
Compare
|
I just rebased my WIP branch off dev-1.13. This should avoid merge conflicts. |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
Pushed to 1.14 |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/XXL
|
Changed base to master so it doesn't clutter my base:dev-1.13 searched |
|
It looks like maybe other changes were accidentally pulled into this. @PatrickLang Do you plan to update this PR or just create a new one? |
|
When this was moved out of v1.13, someone changed the merge target to master which broke a lot of stuff. |
|
@bgrant0607 @spiffxp - how does the release team track doc completion? We should follow whatever that process is for v1.14 |
Based on https://kubernetes.io/docs/tasks/inject-data-application/distribute-credentials-secure/#create-a-pod-that-has-access-to-the-secret-data-through-environment-variables TODO: figure out how to make the link https://k8s.io/docs/getting-started-guides/windows/secret-pod.yaml work - Used same secrets as standard instructions - Used environment variables to inject secrets - Updated windows/secret-pod.yaml to match new instructions - Because pod needs to keep running, add a ping -t localhost so that the pod is never "Completed". Linux uses nginx image, which has a default command. Signed-off-by: Ben Moss <[email protected]>
PatrickLang
force-pushed
the
windows-v1.13
branch
from
ee898b2
to
101d669
Compare
k8s-ci-robot
added
size/XL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@craiglpeters @michmike - I rebased this so you can read my old proposed outline. We're not sure if we're going to keep this PR or have someone else coordinate the docs. We'll discuss in SIG-Windows meeting tomorrow |
|
@PatrickLang I'm not sure what the current process is, but believe it's documented here: I suggest asking on the SIG Docs slack channel or mailing list. |
@PatrickLang I have updated docs deadlines in k/sig-release. Essentially you will need to rebase this against dev-1.14 unless you want to scrap it in favor of another PR. Let me know if I can help! Thanks! |
|
/close |
Windows Server support is proposed as a stable feature (kubernetes/enhancements#116) for v1.13.
This is a documentation overhaul that will include typical steps and use-case based examples for both application developers and cluster operators. The old content was moved into another file, and most of that will be removed to link to existing cluster setup steps instead.
/milestone 1.13
/hold