Skip to content

Add i18n/OWNERS #10811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Nov 2, 2018
Merged

Add i18n/OWNERS #10811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions i18n/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# This is the directory for internationalized site strings.

reviewers:
- sig-docs-pr-reviews

@xiangpengzhao xiangpengzhao Nov 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this group to sig-docs-en-reviews (as its related appovers group is called sig-docs-en-owners)? It's OK as-is, but it may cause kinda confusing in the future.

@zacharysarah zacharysarah Nov 5, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep an easily findable group for docs PRs, but I agree that because it doesn't follow convention that it's unnecessarily confusing. I'll add a separate team for EN reviews following the same naming conventions.

- sig-docs-ja-reviews
- sig-docs-ko-reviews
- sig-docs-zh-reviews

approvers:
- sig-docs-en-owners
- sig-docs-ja-owners
- sig-docs-ko-owners
- sig-docs-zh-owners