Modify loadbalancer docs for external source ip preservation feature #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "type": "LoadBalancer" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
you should explain what this does to achieve the result, including only routing locally, the fact that nodeports are not handled yet, and the basic healthchecks stuff
girishkalele
force-pushed
the
esipp_lb_docs
branch
2 times, most recently
from
02b0238
to
205fb76
Compare
| @@ -37,15 +43,15 @@ Your configuration file might look like: | |||
| "type": "LoadBalancer" | |||
| } | |||
| } | |||
|
|
|||
| ``` | |||
There was a problem hiding this comment.
need a blank line after tick blocks or GH may render it badly
girishkalele
force-pushed
the
esipp_lb_docs
branch
from
205fb76
to
bfffe19
Compare
| Also note this feature is not currently implemented for all cloudproviders/environments. | ||
|
|
||
| ### Caveats and Limitations when preserving source IPs | ||
|
|
There was a problem hiding this comment.
Still want a note that this does not yet work on nodePorts, so "proxy style" balancers can not use this yet.
|
One nit then docs LGTM |
girishkalele
force-pushed
the
esipp_lb_docs
branch
from
bfffe19
to
cb8e58f
Compare
|
Fixed nit...marking LGTM. |
girishkalele
force-pushed
the
esipp_lb_docs
branch
from
cb8e58f
to
3ebf1ff
Compare
|
Rebased. |
|
Fixes #1058 |
|
needs a rebase |
girishkalele
force-pushed
the
esipp_lb_docs
branch
from
345d13c
to
f1fb380
Compare
|
I tried the "Update branch" button but it does a pull instead of a rebase. Rebased manually instead. |
|
cc @kubernetes/docs |
mikutas
pushed a commit
to mikutas/k8s-website
that referenced
this pull request
Sep 22, 2022
Signed-off-by: Charles Pretzer <[email protected]>
Okabe-Junya
pushed a commit
to Okabe-Junya/website
that referenced
this pull request
Dec 4, 2023
…s/rojopolis/spellcheck-github-actions-0.25.0 chore(deps): bump rojopolis/spellcheck-github-actions from 0.24.0 to 0.25.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - here is the first crack at explaining the new annotation and feature gate.
This change is