address additional comments from pr #10259 #10539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes-docs-i18n-bot
added
the
language/en
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit b819e62 https://deploy-preview-10539--kubernetes-io-master-staging.netlify.com |
kbhawkey
reviewed
Oct 8, 2018
| @@ -191,7 +191,7 @@ I am a plugin with a dash in my name | |||
|
|
|||
| #### Name conflicts and overshadowing | |||
|
|
|||
| It can be possible to have multiple pluins with the same filename in different locations throughout your PATH. | |||
| It can be possible to have multiple plugins with the same filename in different locations throughout your PATH. | |||
juanvallejo
force-pushed
the
pick-pr-10422
branch
from
dbbd282
to
6853276
Compare
|
A rebase is needed to resolve the conflicts, otherwise this one looks good to me. |
k8s-ci-robot
added
the
lgtm
juanvallejo
force-pushed
the
pick-pr-10422
branch
from
6853276
to
b819e62
Compare
k8s-ci-robot
removed
the
lgtm
|
@tengqm Thanks, rebased PR |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10422 merged into 1.12 branch.
Picking into master
cc @soltysh