Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile user experience on pages under /docs #10072

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Improve mobile user experience on pages under /docs #10072

merged 1 commit into from
Oct 16, 2018

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Aug 24, 2018 •
edited
Loading

Force #docs #vendorStrip elements to use overflow-x: scroll in CSS.

Closes #10067
Replaces #10068

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 24, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5be6a82

https://deploy-preview-10072--kubernetes-io-master-staging.netlify.com

@xiangpengzhao xiangpengzhao requested review from bep and removed request for xiangpengzhao August 24, 2018 08:35
@bep bep removed their request for review August 24, 2018 08:57
@tnir
Copy link
Contributor Author

tnir commented Aug 24, 2018

@xiangpengzhao @bep Thanks for handling this PR. While I confirmed if this PR works in my local env (with make docker-serve)

Preview hosted by Netlify doesn't work well: https://deploy-preview-10072--kubernetes-io-master-staging.netlify.com/docs/

What should I check about previewing with Netlify for this repository?

@tnir tnir mentioned this pull request Aug 24, 2018
Closed
@zparnold
Copy link
Member

zparnold commented Oct 4, 2018

@tnir Please resolve merge conflicts so we can continue

@tnir tnir force-pushed the 10067-docs-vendorstrip-overflow-v2 branch from 6382674 to 40c36ce Compare October 8, 2018 04:27
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2018
@tnir
Copy link
Contributor Author

tnir commented Oct 8, 2018

/test all

@tnir tnir force-pushed the 10067-docs-vendorstrip-overflow-v2 branch from 40c36ce to 4995873 Compare October 8, 2018 05:27
@tnir
Copy link
Contributor Author

tnir commented Oct 8, 2018

@zparnold I just confirmed both that there is no conflict and that this PR works well at https://deploy-preview-10072--kubernetes-io-master-staging.netlify.com/docs/home/

/assign @zparnold

@zacharysarah
Copy link
Contributor

@tnir 👋 This PR still has a merge conflict with static/css/styles.css. Please feel free to reopen when you've resolved the conflict.

@tnir
Copy link
Contributor Author

tnir commented Oct 16, 2018

/reopen

@k8s-ci-robot
Copy link
Contributor

@tnir: Reopening this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@tnir: failed to re-open PR: state cannot be changed. The 10067-docs-vendorstrip-overflow-v2 branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnir
Copy link
Contributor Author

tnir commented Oct 16, 2018

/reopen

@k8s-ci-robot
Copy link
Contributor

@tnir: Reopening this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 16, 2018
@tnir tnir force-pushed the 10067-docs-vendorstrip-overflow-v2 branch from 4995873 to b4317df Compare October 16, 2018 06:38
@tnir
Improve mobile user experience on pages under /docs
5be6a82 
Force #docs #vendorStrip elements to use overflow-x: scroll in CSS.

Signed-off-by: Takuya Noguchi <[email protected]>
@tnir tnir force-pushed the 10067-docs-vendorstrip-overflow-v2 branch from b4317df to 5be6a82 Compare October 16, 2018 06:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2018
@tnir
Copy link
Contributor Author

tnir commented Oct 16, 2018

@zacharysarah Thanks. Just reopened and fixed the PR, which is ready to be merged at this moment 😄

@tnir
Copy link
Contributor Author

tnir commented Oct 16, 2018

/assign @zacharysarah

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit ad54de4 into kubernetes:master Oct 16, 2018
@tnir tnir deleted the 10067-docs-vendorstrip-overflow-v2 branch October 16, 2018 14:14
@chenopis
Copy link
Contributor

/cc @Bradamant3
I think this PR inadvertently caused a UI issue. I'm seeing this:

screen shot 2018-10-19 at 3 52 30 pm

There is an extra gray bar underneath the secondary nav and search box.

If you compare the two deploy previews:

Can this be addressed?

@chenopis chenopis mentioned this pull request Oct 19, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@Bradamant3 Bradamant3 Awaiting requested review from Bradamant3

Assignees

@zacharysarah zacharysarah

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tnir @k8sio-netlify-preview-bot @zparnold @zacharysarah @k8s-ci-robot @chenopis @kubernetes-docs-i18n-bot