Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated kubeadm docs for 1.11 are inconsistently formatted during release cycle #8723

Closed
1 of 2 tasks
Bradamant3 opened this issue May 24, 2018 · 5 comments
Closed
1 of 2 tasks
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@Bradamant3
Copy link
Contributor

This is a...

  • Feature Request
  • Bug Report

Problem:
kubeadm docs generated during the 1.11 release cycle by anyone other than @tengqm do not include the HTML formatting that was added for 1.10. This is because kubernetes-sigs/reference-docs#47 is not merged.

Proposed Solution:
Life with mismatched formatting until 1.11 release. sig-docs regenerates all generated docs per release. At release time, if the PR is merged we'll have pretty tables for everything. If it isn't merged, we'll have less pretty lists for everything. But the inconsistencies will be gone.

Page to Update:
includes for siblings of https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm/
(source at https://github.com/kubernetes/website/tree/master/content/en/docs/reference/setup-tools/kubeadm/generated)

@lucperkins
Copy link
Contributor

@Bradamant3 Was this addressed by #8617? If so, could you close this issue?

@lucperkins lucperkins added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 9, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 7, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 6, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

4 participants