Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need top-level Controllers concept guide #4135

Closed
1 of 2 tasks
erictune opened this issue Jun 19, 2017 · 31 comments
Closed
1 of 2 tasks

Need top-level Controllers concept guide #4135

erictune opened this issue Jun 19, 2017 · 31 comments
Assignees
Labels
language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@erictune
Copy link
Member

This is a...

  • Feature Request
  • Bug Report

Problem:

No overarching Concept guide for controllers.

Proposed Solution:

Write one.

Page to Update:
New page to be added.

We have Concept docs for various controllers:

  • docs/concepts/workloads/controllers/deployment.md
  • docs/concepts/workloads/controllers/daemonset.md
  • docs/concepts/workloads/controllers/replicaset.md
  • docs/concepts/workloads/controllers/replicationcontroller.md
  • docs/concepts/workloads/controllers/statefulset.md

We have Tasks for types of applications:

  • docs/tasks/run-application/run-single-instance-stateful-application.md
  • docs/tasks/run-application/run-stateless-application-deployment.md
  • docs/tasks/run-application/run-replicated-stateful-application.md

We do not have an overarching doc that covers the following use cases:

  • To define what we mean by the word controller.
  • To help the users select the right one
  • To explain concepts common to all controllers.
  • To explain that there are built-in controllers, but that users can write their own (Operators).

@kubernetes/sig-apps-feature-requests

@erictune
Copy link
Member Author

There is an incomplete list of controllers in docs/concepts/workloads/pods/pod-lifecycle.md

@erictune
Copy link
Member Author

Common responsibilities for Kubernetes controllers:

  • Kubernetes controllers automatically create replacement pods in the face of node failures.
  • Kubernetes controllers aggregate status of their pods, so that the CLI and UI can summarize.
  • and so on.

@enisoc
Copy link
Member

enisoc commented Jun 22, 2017

+1 I would have liked to link to such a doc from #4071.

@erictune
Copy link
Member Author

Also, this doc could talk about roll-forward and back in a general way, across SS, DS, Deployment, RS. And ControllerRevision.

@erictune
Copy link
Member Author

erictune commented Jul 7, 2017

Started a draft for this here:
https://docs.google.com/document/d/1jDPTKIRUf_UaVUu_BNu9IxXZR61rZ4MLPDRDWOevczg/view

Collecting content.

@metmajer
Copy link

@erictune: this is going to be a very valuable feature. Is there any way I could help out with this PR?

@markmandel
Copy link
Contributor

markmandel commented Nov 28, 2017

How can I also get involved? I think it would be great if this resource existed - especially separate from CRDS (as they may not necessarily go together). I have a huge list of external examples and resources I used to learn about Controllers, happy to add them to the google doc if it helps / review / whatever.

Here is my Friction Log if it helps.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2018
@erictune
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2018
@nikhita
Copy link
Member

nikhita commented May 27, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2018
@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

/remove-lifecycle rotten

still relevant.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 25, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2018
@erictune
Copy link
Member Author

erictune commented Dec 24, 2018 via email

@bradtopol
Copy link
Contributor

@markmandel @metmajer @erictune We would love to see this content get completed. Would one of you be willing to take the lead on generating the content? I can help with any questions you may have on submitting a PR

@erictune
Copy link
Member Author

erictune commented Feb 28, 2019 via email

@sftim
Copy link
Contributor

sftim commented May 25, 2019

I'm sketching out how to do this. I won't /assign it to myself; if anyone wants to join in, I'll be happy to collaborate.

@sftim
Copy link
Contributor

sftim commented Jun 4, 2019

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 4, 2019
@sftim
Copy link
Contributor

sftim commented Jun 4, 2019

#12323 might be (very slightly) relevant here

@zacharysarah
Copy link
Contributor

@sethmccombs 👋 Thanks for following up with @sftim.

@sftim
Copy link
Contributor

sftim commented Jun 19, 2019

I've got a big bunch of changes that apply cleanly to master.

I'm going to wait for Kubernetes v1.15 to be out and for the dust to settle. Then I'll make branches with subsets of the overall changes and send in pull requests (there could be several size/XXL PRs to come from this).

@zacharysarah
Copy link
Contributor

@sftim 👋 Any updates?

@sftim
Copy link
Contributor

sftim commented Jul 7, 2019

I've been away-from-keyboard for a week. Will update this.

@bradtopol
Copy link
Contributor

Thanks @sftim please feel free to ping me when its ready for review

sftim added a commit to sftim/kubernetes-website that referenced this issue Jul 11, 2019
sftim added a commit to sftim/kubernetes-website that referenced this issue Aug 7, 2019
@zacharysarah zacharysarah removed the P2 label Sep 10, 2019
@sftim
Copy link
Contributor

sftim commented Sep 10, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 10, 2019
@sftim
Copy link
Contributor

sftim commented Sep 17, 2019

/status active

@sftim
Copy link
Contributor

sftim commented Oct 3, 2019

/close
Resolved by #15733
If there's part of the task still left to do, I recommend opening a new issue and referencing this closed one.

@k8s-ci-robot
Copy link
Contributor

@sftim: Closing this issue.

In response to this:

/close
Resolved by #15733
If there's part of the task still left to do, I recommend opening a new issue and referencing this closed one.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

10 participants