Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Localize /en/docs/reference/glossary/app-container.md #35941

Closed
rolfedh opened this issue Aug 13, 2022 · 11 comments
Closed

[hi] Localize /en/docs/reference/glossary/app-container.md #35941

rolfedh opened this issue Aug 13, 2022 · 11 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/hi Issues or PRs related to Hindi language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rolfedh
Copy link
Contributor

rolfedh commented Aug 13, 2022

[hi] Localize /en/docs/reference/glossary/app-container.md

Instructions

Translating the frontmatter

In the frontmatter, that is, between the --- markers that enclose the first dozen lines:

  • Translate the title and short_description values.
  • Do not translate the id, aka, tags values. We will systematically translate those later on in a separate project.

Translating the content body

Below the frontmatter, in the content body:

  • Translate almost everything.
  • If you encounter a glossary shortcode, for example, {{< glossary_tooltip text="containers" term_id="container" >}}, translate the text value. But do not translate the term_id value.

Procedure:

  1. In this issue, assign this issue to yourself by commenting: /assign <your_github_id>
  2. Open PR [hi] Localize app-container.md #35942.
  3. In the PR, select all the lines in the file and click + to comment. Screenshot 1
  4. In the comment, click the +/- suggestion icon (screenshot 2). Screenshot 2
  5. In the suggestion, localize the content to Hindi.
  6. IMPORTANT: Click the Start a review button.
  7. IMPORTANT: Click Review changes, Comment, and Submit review. Screenshot 3

Note: By completing these steps, your GitHub profile will give you credit for performing a code review!

As follow-up steps, I will do the following:

  • Apply your suggested localization to the PR.
  • Ask a reviewer to review the localized content.
  • Update the content as needed.
  • Get the PR approved and merged.

This feature issue is part of the following project:

@rolfedh rolfedh added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 13, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 13, 2022
@rolfedh
Copy link
Contributor Author

rolfedh commented Aug 14, 2022

/language hi
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@rolfedh:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/language hi
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 14, 2022
@bishal7679
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 14, 2022
@taniaduggal
Copy link
Contributor

/assign

@nitishfy
Copy link
Member

@rolfedh I appreciate your contribution! Here's a little suggestion:

Please assign the issue to yourself before raising the PR for that issue. @taniaduggal self-assigned her first but the PR was raised by you. This might lead to sudden confusion.

@taniaduggal
Copy link
Contributor

@nitishkumar06 I firstly checked the file,it is not localize . That's why I assigned it to myself.

@bishal7679
Copy link
Member

@nitishkumar06 Thanks for giving your valuable time 👍
Actually some misunderstanding happened here. I think @rolfedh raised a demo PR for this term in english which has not localized in hindi yet. Thats why @taniaduggal got assigned.

@rolfedh
Copy link
Contributor Author

rolfedh commented Aug 16, 2022

@nitishkumar06 @taniaduggal @bishal7679 I created two issues like this one, each linked to PRs that contain an unlocalized file. I intended to provide a way for absolute newcomers to contribute localized content by using comments. This way they don't need to sign a CLA, setting up a fork/local clone of the repo, learning git, etc.

I welcome anyone self-assigning these issues to take on the localization task. Please provide feedback to help me improve it for future contributors.

After I have this raft of issues and pull requests merged, let's do a quick retrospective. I'll use your feedback to update the templates and processes we use to help avoid any confusion as we scale this up to more and more contributors.

Here's the original explanation of this experiment: #35600 (comment)

@taniaduggal
Copy link
Contributor

/assign @anubha-v-ardhan

@nitishfy
Copy link
Member

/assign

@nitishfy
Copy link
Member

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/hi Issues or PRs related to Hindi language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants