Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide between KubeSchedulerConfig versions #30063

Closed
alculquicondor opened this issue Oct 12, 2021 · 18 comments
Closed

Migration guide between KubeSchedulerConfig versions #30063

alculquicondor opened this issue Oct 12, 2021 · 18 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Oct 12, 2021

What would you like to be added

A section in this page https://kubernetes.io/docs/reference/scheduling/config/ with migration instructions between API versions (v1beta1 to v1beta2 and v1beta2 to v1beta3), similar to this https://kubernetes.io/docs/reference/using-api/deprecation-guide

Why is this needed

This is specially important after the removal of v1beta1 (kubernetes/kubernetes#104782) and the introduction of v1beta3 (kubernetes/kubernetes#104251)

Comments

The information can be recovered from release notes, although I admit they are scattered.

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.22.md#api-change

At least these changes are related:

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 12, 2021
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 12, 2021
@alculquicondor
Copy link
Member Author

@kerthcet do you think you can take this?

FYI @damemi @ravisantoshgudimetla

@alculquicondor
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 12, 2021
@sftim
Copy link
Contributor

sftim commented Oct 12, 2021

If there are lots of steps:

@alculquicondor
Copy link
Member Author

The steps are 3 to 5 for each case. Does that grant a page?

@liggitt
Copy link
Member

liggitt commented Oct 12, 2021

when considering where to put this, let's do it in a way that would make sense for something similar for v1beta2 → v1beta3 config, and v1beta3 → v1

@sftim
Copy link
Contributor

sftim commented Oct 12, 2021

when considering where to put this, let's do it in a way that would make sense for something similar for v1beta2 → v1beta3 config, and v1beta3 → v1

One page, with tabs?

Things that suggest a task:

  • detailed prerequisites
  • lots of steps
  • potential for errors / rework / troubleshooting

Things that favor embedding in the reference page:

  • one static step; if there are multiple steps, they are the kind of steps you can combine using && in a POSIX shell
  • the reference docs provide lots of context for the steps in question

@sftim
Copy link
Contributor

sftim commented Oct 12, 2021

We could also consider making a whole section of tasks around upgrading. That might cover:

and more!

@alculquicondor
Copy link
Member Author

Note that configuration files don't work with kubectl. I think they should be treated separately.

I think the changes won't make enough content for a task (at least for v1beta1 to v1beta2). It's just a handful of bullet points.

Maybe we will require a task for v1beta3 @damemi

@liggitt
Copy link
Member

liggitt commented Oct 12, 2021

I think they should be treated separately.

I agree. The audiences are separate as well (end-users / REST API users, who are legion, vs kube-scheduler admins, which are far more rare)

@sftim
Copy link
Contributor

sftim commented Oct 12, 2021

just a handful of bullet points

Sounds like a case for leaving it in the page. We can always migrate later.

@tengqm
Copy link
Contributor

tengqm commented Oct 13, 2021

I think the original proposal is as good as it stands.

@kerthcet
Copy link
Member

@kerthcet do you think you can take this?

FYI @damemi @ravisantoshgudimetla

yeah, I can work on this if nobody assigned.

@alculquicondor
Copy link
Member Author

/assign @kerthcet

@mehabhalodiya
Copy link
Contributor

mehabhalodiya commented Dec 3, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 3, 2021
@mehabhalodiya
Copy link
Contributor

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 3, 2021
@kerthcet
Copy link
Member

kerthcet commented Dec 3, 2021

kindly reminding @mehabhalodiya , v1beta1 -> v1beta2 and v1beta2 -> v1beta3 document migration has been merged.

@mehabhalodiya
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@mehabhalodiya: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants