Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue generators listing with k8s.io/docs/reference/kubectl/conventions/ #12090

Closed
1 of 2 tasks
ryandawsonuk opened this issue Jan 5, 2019 · 9 comments
Closed
1 of 2 tasks
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ryandawsonuk
Copy link

This is a...

  • Feature Request
  • Bug Report

Problem:
The documentation at https://kubernetes.io/docs/reference/kubectl/conventions/#generators suggests that I should be able to use the generator extensions/v1beta1 much as deployment/v1beta1 as it lists kubectl run --generator=extensions/v1beta1 right next to kubectl run --generator=deployment/v1beta1, with the latter being recommended.

But is the difference really that one is recommended and the other not? kubectl run --generator=deployment/v1beta1 foobar --image=nginx -o yaml --dry-run works but with extensions/v1beta1 you get error: generator "apps/v1beta1" not found (e.g. when running via the interactive environment in https://kubernetes.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive/).

Proposed Solution:
Either remove the non-recommended options or clarify how or when they can be used.

Page to Update:
https://kubernetes.io/docs/reference/kubectl/conventions/#generators

@tengqm
Copy link
Contributor

tengqm commented Jan 7, 2019

Looks like we need both code patches and doc patches for this.
@janetkuo

@ryandawsonuk ryandawsonuk changed the title Issue generators listig with k8s.io/docs/reference/kubectl/conventions/ Issue generators listing with k8s.io/docs/reference/kubectl/conventions/ Jan 8, 2019
@DanyC97
Copy link
Contributor

DanyC97 commented Mar 3, 2019

i think we need to also understand when the deprecation of the generators is coming in - see https://stackoverflow.com/questions/52890718/kubectl-run-is-deprecated-looking-for-alternative

@soltysh any insights when this might be targeted ? maybe we can remove the entire section from the docs

@soltysh
Copy link
Contributor

soltysh commented Mar 5, 2019

@soltysh any insights when this might be targeted ? maybe we can remove the entire section from the docs

Generator were deprecated in 1.12, so we'll need to wait to 1.15 at least to get that removed. We should update the docs but clearly state it's deprecated functionality. Also we need to fix code where needed.

@DanyC97
Copy link
Contributor

DanyC97 commented Mar 5, 2019

thank you for taking the time to respond.
I'll go over each of the generator and then post here which one works, which one doesn't and then update the docs.

@DanyC97
Copy link
Contributor

DanyC97 commented Mar 13, 2019

/assign @DanyC97

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 11, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants