Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for kube-dns for comparison with CoreDNS #9921

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

rajansandeep
Copy link
Contributor

This PR achieves the same goals as #7838

Ability to verify tests results of CoreDNS against kube-dns

CoreDNS is expected to replace kube-dns. See KEP : kubernetes/community#1956

One of the graduation criteria is to be able to:

Validate all e2e conformance and DNS related tests (xxx-kubernetes-e2e-gce, ci-kubernetes-e2e-gce-gci-ci-master and filtered by --ginkgo.skip=[Slow]|[Serial]|[Disruptive]|[Flaky]|[Feature:.+]) for CoreDNS. None of the tests successful with Kube-DNS should be failing with CoreDNS.

I propose here these 2 extra tests that will run always with kube-dns, whatever the default DNS service defined for K8s:

  • the test for graduation criteria
  • another test to validate the [Serial], [Slow] (but not Flaky). These tests includes some other DNS - specifics (like updating the DNS configuration by configMap).

/assign @fejta @MrHohn

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2018
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/testgrid labels Oct 25, 2018
@rajansandeep
Copy link
Contributor Author

FYI @fturib

@fejta
Copy link
Contributor

fejta commented Oct 25, 2018

/approve

testgrid changes

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3e6d9ee662986f9d6052a26a5d6284bd688e717

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7d66f97 into kubernetes:master Oct 25, 2018
@k8s-ci-robot
Copy link
Contributor

@rajansandeep: Updated the job-config configmap using the following files:

  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

This PR achieves the same goals as #7838

Ability to verify tests results of CoreDNS against kube-dns

CoreDNS is expected to replace kube-dns. See KEP : kubernetes/community#1956

One of the graduation criteria is to be able to:

Validate all e2e conformance and DNS related tests (xxx-kubernetes-e2e-gce, ci-kubernetes-e2e-gce-gci-ci-master and filtered by --ginkgo.skip=[Slow]|[Serial]|[Disruptive]|[Flaky]|[Feature:.+]) for CoreDNS. None of the tests successful with Kube-DNS should be failing with CoreDNS.

I propose here these 2 extra tests that will run always with kube-dns, whatever the default DNS service defined for K8s:

  • the test for graduation criteria
  • another test to validate the [Serial], [Slow] (but not Flaky). These tests includes some other DNS - specifics (like updating the DNS configuration by configMap).

/assign @fejta @MrHohn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants