Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove etcd2 upgrade/downgrade jobs #9677

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 3, 2018

ref: #7602
ref: kubernetes/enhancements#622
ref: kubernetes/kubernetes#69310

Followup to #9672

As we are no longer supporting etcd2 in v1.13, we no longer need
these jobs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config labels Oct 3, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Oct 3, 2018

/cc @BenTheElder @timothysc

/cc @AishSundar @jberkus
Giving you a heads up as 1.13 release lead and CI signal, this is going to make a sig-release dashboard go away. That said, it's not one we've paid attention to during release cycles

@spiffxp spiffxp force-pushed the rm-etcd2-from-remaining-tests branch from 1ae1651 to f231ce1 Compare October 3, 2018 17:21
@AishSundar
Copy link
Contributor

thanks @spiffxp for doing this :) Please remove the hold when ready to merge

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AishSundar, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Oct 3, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9c812a8 into kubernetes:master Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap using the following files:

  • key sig-cluster-lifecycle-misc.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/sig-cluster-lifecycle-misc.yaml
  • key k8s-upgrade-gce.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/k8s-upgrade-gce.yaml

In response to this:

ref: #7602
ref: kubernetes/enhancements#622
ref: kubernetes/kubernetes#69310

Followup to #9672

As we are no longer supporting etcd2 in v1.13, we no longer need
these jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the rm-etcd2-from-remaining-tests branch October 3, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants