Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kubetest + kubekins-e2e #6871

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Bump kubetest + kubekins-e2e #6871

merged 2 commits into from
Feb 16, 2018

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Feb 16, 2018

This pulls in #6846, #6861, #6864, #6870, and maybe other things.

cc @porridge @shyamjvs @dims @filbranden

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2018
krzyzacy
krzyzacy reviewed Feb 16, 2018
View reviewed changes
scenarios/kubernetes_e2e.py
@@ -36,7 +36,7 @@
ORIG_CWD = os.getcwd() # Checkout changes cwd

# Note: This variable is managed by experiment/bump_e2e_image.sh.
DEFAULT_KUBEKINS_TAG = 'v20180212-83c830734-master'
DEFAULT_KUBEKINS_TAG = 'v20180216-90c54ef53-master'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol we won't need this anymore, I'll clean it up in a bit

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2018
krzyzacy
krzyzacy approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2018
@BenTheElder
Copy link
Member

/lgtm

Probably will do some more bumping soon for experimental images, today is the day of image bumping 😂

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,ixdy,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-canary/11962
once this is green should be good to merge

@BenTheElder BenTheElder mentioned this pull request Feb 16, 2018
Merged
@BenTheElder
Copy link
Member

Green run above I0216 21:54:32.555] Image: gcr.io/k8s-testimages/kubekins-e2e:v20180216-90c54ef53-master

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 46dbe2d into kubernetes:master Feb 16, 2018
@k8s-ci-robot
Copy link
Contributor

@ixdy: Updated the config configmap

In response to this:

This pulls in #6846, #6861, #6864, #6870, and maybe other things.

cc @porridge @shyamjvs @dims @filbranden

/assign @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy ixdy deleted the bump-kubekins branch May 15, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@BenTheElder BenTheElder

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ixdy @BenTheElder @k8s-ci-robot @krzyzacy