Set up a test-infra PR job.

[spxtr]

This PR makes ciongke handle multiple repos properly and adds a gotest job to PR Jenkins for the test-infra repo. This new PR job won't add any "ok to test" messages since it isn't triggered by the usual plugin :).

The remaining multirepo problem that this doesn't solve is #476. Until that's fixed I'm not going to bother uploading logs.

After this goes in and I've made sure things look reasonable I'll make a tiny PR switching off dry-run. !!

---

This change is

[rmmh]

Reviewed 5 of 6 files at r1.
Review status: 5 of 6 files reviewed at latest revision, 4 unresolved discussions.

---

ciongke/cmd/hook/githubagent_test.go, line 315 [r1] (raw file):

          "@k8s-bot test this",
          []string{"cadveapster"},
      },

Add a case for org/randomrepo with an empty expectedjobs list.

---

ciongke/cmd/hook/main.go, line 48 [r1] (raw file):

// Repo FullName (eg "kubernetes/kubernetes") -> []JenkinsJob
var defaultJenkinsJobs = map[string][]JenkinsJob{

This should probably become a JSON/YAML file and live in a ConfigMap in the future. :-)

---

ciongke/cmd/hook/main.go, line 49 [r1] (raw file):

// Repo FullName (eg "kubernetes/kubernetes") -> []JenkinsJob
var defaultJenkinsJobs = map[string][]JenkinsJob{
  "kubernetes/test-infra": []JenkinsJob{

[]JenkinsJob is unnecessary here.

---

jenkins/job-configs/kubernetes-jenkins-pull/testinfra-pull.yaml, line 62 [r1] (raw file):

        - shell: |
            cd ${WORKSPACE}/go/src/github.com/kubernetes/test-infra
            go test $(go list ./... | grep -v vendor)

I assume this is basically a dummy test job -- if we want this to be more legit, it'll need log publishing to GCS. (it might be a good test-case for upload-to-gcs.sh changes)

---

Comments from Reviewable

[spxtr]

Review status: 3 of 6 files reviewed at latest revision, 4 unresolved discussions.

---

ciongke/cmd/hook/githubagent_test.go, line 315 [r1] (raw file):

Previously, rmmh (Ryan Hitchman) wrote…

Add a case for org/randomrepo with an empty expectedjobs list.

Done.

---

ciongke/cmd/hook/main.go, line 48 [r1] (raw file):

Previously, rmmh (Ryan Hitchman) wrote…

This should probably become a JSON/YAML file and live in a ConfigMap in the future. :-)

Agreed.

---

ciongke/cmd/hook/main.go, line 49 [r1] (raw file):

Previously, rmmh (Ryan Hitchman) wrote…

[]JenkinsJob is unnecessary here.

Done.

---

jenkins/job-configs/kubernetes-jenkins-pull/testinfra-pull.yaml, line 62 [r1] (raw file):

Previously, rmmh (Ryan Hitchman) wrote…

I assume this is basically a dummy test job -- if we want this to be more legit, it'll need log publishing to GCS. (it might be a good test-case for upload-to-gcs.sh changes)

Yes, agreed.

---

Comments from Reviewable

[rmmh]

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

Comments from Reviewable

[spxtr]

Thanks for the prompt review.