Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping in charts-pull #460

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Conversation

viglesiasce
Copy link
Contributor

@viglesiasce viglesiasce commented Aug 27, 2016

I believe that the job is failing at the moment due to improper escaping of the environment variables.


This change is Reviewable

@spxtr
Copy link
Contributor

spxtr commented Aug 29, 2016

You're correct, because it's not a template anymore you don't need to escape those. You can see on travis lines like

-        <refspec>+refs/pull/${{ghprbPullId}}/merge:refs/remotes/origin/pr/${{ghprbPullId}}/merge</refspec>
+        <refspec>+refs/pull/${ghprbPullId}/merge:refs/remotes/origin/pr/${ghprbPullId}/merge</refspec>

which is just what you want :)

@spxtr spxtr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2016
@spxtr spxtr merged commit fffba53 into kubernetes:master Aug 29, 2016
@viglesiasce viglesiasce deleted the add-charts-pull branch August 29, 2016 19:12
@ixdy ixdy mentioned this pull request Aug 30, 2016
ostromart pushed a commit to ostromart/test-infra that referenced this pull request Jul 26, 2019
Automatic merge from submit-queue

Put back rbac_auth

**Release note**:

```release-note
none
```
grantr pushed a commit to grantr/test-infra that referenced this pull request Feb 21, 2020
* Create xml output from testcases for testgrid

* Updte apicoverage to handle method signatur update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants