Map in output directory when KUBE_RUN_FROM_OUTPUT is set #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "${docker_extra_args[@]:+${docker_extra_args[@]}}" \ | ||
| gcr.io/google-containers/kubekins-e2e:v20160817 | ||
| gcr.io/google-containers/kubekins-e2e:v201608XX |
|
LGTM generally, will you assign this back to me when the image is ready and this is ready for final review? |
|
|
|
LGTM Consider ensuring that the new runner and image work in jenkins before switching over all jobs. |
fejta
added
the
lgtm
|
I've updated this PR so we're still using the last-stable |
|
Nice! LGTM |
Additionally: * deprecate KUBEKINS_SERVICE_ACCOUNT_FILE in favor of GOOGLE_APPLICATION_CREDENTIALS. * allow overriding kubekins-e2e image tag
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Aug 23, 2016
Automatic merge from submit-queue Use kubekins-test:v20160822 everywhere A step towards fixing #31148. We also need to update the test-infra repo to use the new e2e image. I'll fold that into kubernetes/test-infra#419. Both gcr.io/google-containers/kubekins-test:v20160822 and gcr.io/google-containers/e2e-test:v20160822 have already been pushed.
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
* Ignore long lines by default (current behavior) * Allow per-repo custom config in `/test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to support dockerized e2e on PR Jenkins.
I'm additionally retiring
KUBEKINS_SERVICE_ACCOUNT_FILEin favor ofGOOGLE_APPLICATION_CREDENTIALS.This should not be merged until kubernetes/kubernetes#31035 is merged and a new image is pushed.
A step along the way for #318.
This change is