Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON output to the PR dashboard. #418

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Conversation

rmmh
Copy link
Contributor

@rmmh rmmh commented Aug 19, 2016

This is for consumption by other tools.


This change is Reviewable

@@ -94,6 +95,21 @@ def get(self, user=None):
qs.append(ghm.GHIssueDigest.involved == user)
prs = list(ghm.GHIssueDigest.query(*qs))
prs.sort(key=lambda x: x.updated_at, reverse=True)

if self.request.headers.get('Accept') == 'application/json':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

Consider also adding a way to enable this behavior from the browser by changing the request URI somehow.

@fejta
Copy link
Contributor

fejta commented Aug 19, 2016

/lgtm

This is for consumption by other tools.
@fejta
Copy link
Contributor

fejta commented Aug 19, 2016

/lgtm

@fejta fejta added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2016
@rmmh rmmh merged commit bffc9b8 into kubernetes:master Aug 19, 2016
@rmmh rmmh deleted the pr_json branch January 10, 2018 22:43
ostromart pushed a commit to ostromart/test-infra that referenced this pull request Jul 26, 2019
Automatic merge from submit-queue

Add assign plugin to all repos

**Release note**:

```release-note
none
```
grantr pushed a commit to grantr/test-infra that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants