Use dockerized e2e in PR Jenkins when special file exists #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export PATH=${{PATH}}:/usr/local/go/bin | ||
| exit | ||
| fi | ||
| # Nothing should want Jenkins $HOME |
There was a problem hiding this comment.
GitHub is doing a poor job of illustrating this diff, but I just made the release-1.0/release-1.1 case exit so I could remove the "else" and all of its indentation.
ixdy
force-pushed
the
dockerized-e2e
branch
2 times, most recently
from
acc2b72 to
4e883ab
Compare
|
I assume you're going to make a PR that touches that file and ensure it works? |
|
Yes, that's the idea. :) |
spxtr
added
the
lgtm
| @@ -373,7 +373,11 @@ | |||
| # Get golang into our PATH so we can run e2e.go | |||
| export PATH=${{PATH}}:/usr/local/go/bin | |||
|
|
|||
| timeout -k 15m 55m ./hack/jenkins/e2e-runner.sh && rc=$? || rc=$? | |||
| if [[ -e "./hack/jenkins/.use_dockerized_e2e" ]]; then | |||
There was a problem hiding this comment.
I'm not executing this file - just using it as a marker to trigger the dockerized code path.
There was a problem hiding this comment.
Yes, ok misread. Thought it was the same as the .sh below
foxish
pushed a commit
to foxish/test-infra
that referenced
this pull request
Jan 21, 2017
Add kubernetes-test-go to build blockers
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
* Ignore localhost links by default * Allow per-repo custom config in /test Bonus: make library tests less verbose, and its output clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably just works, but I'd like to test it first before I break the world. It'll use the existing method unless
./hack/jenkins/.use_dockerized_e2eexists.After we verify that it works, we can remove this conditional.
A step towards fixing #318.