Link build results to testgrid (fixes #272). #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2016 16:35
Also, delete some pr tests that were previously moved.
It handles basic field types and can give particular field numbers names. This is enough to parse the testgrid config.proto for what we need.
| @@ -102,6 +102,7 @@ class BuildHandler(view_base.BaseHandler): | |||
| def get(self, prefix, job, build): | |||
| self.check_bucket(prefix) | |||
| job_dir = '/%s/%s/' % (prefix, job) | |||
| testgrid_query = testgrid.path_to_query(job_dir[1:-1]) | |||
There was a problem hiding this comment.
testgrid wants paths like 'kubernetes-jenkins/jobs/gce-e2e'
I can move this stripping into the path_to_query bit.
rmmh
changed the title
rmmh
force-pushed
the
g8r-testgrid
branch
2 times, most recently
from
1be771a to
61243cc
Compare
|
|
||
|
|
||
| def get_config(): | ||
| global _testgrid_config # pylint: disable=global-statement |
There was a problem hiding this comment.
Not a huge fan of this global.
There was a problem hiding this comment.
Do you have any preferences for alternatives?
There was a problem hiding this comment.
If you need it to be loaded once and then used multiple times then load it once at the start and then pass it to whoever uses it.
added 2 commits
August 10, 2016 18:21
the Testgrid configuration protobuf and parsing it. The Testgrid configuration is cached in memory for the instance. There is no expiration/reloading functionality for these configurations-- instead, the assumption is that instances will restart every few hours, so the maximum staleness is negligible.
If there is a testgrid page for the job being considered, link to: - the testgrid tab showing all results for the job - the testgrid tab, filtered to only show results for a failing test
ostromart
pushed a commit
to ostromart/test-infra
that referenced
this pull request
Jul 26, 2019
grantr
pushed a commit
to grantr/test-infra
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy to view historical failures for a job or test.
The neatest / grossest thing here is in
pb_glance.py-- a tiny protobuf parser in 40 lines of code. Seepr_glance_test.pyfor more usage information.