Skip to content

Conversation

@iholder101
Copy link
Contributor

@iholder101 iholder101 commented Jul 1, 2025

Start running memory eviction tests on the swap-conformance lane.

This was already tried in #34507 and later reverted in #34558.

However, after trying to run this locally with:

make test-e2e-node PARALLELISM=1 CLEANUP=true DELETE_INSTANCES=true FOCUS="NodeSwap|MemoryAllocatableEviction|PriorityMemoryEvictionOrdering" SKIP="dummy" SSH_USER="core" KUBE_SSH_USER=core REMOTE=true RUNTIME=remote USE_DOCKERIZED_BUILD=false IMAGE_CONFIG_FILE="/workspace/test-infra/jobs/e2e_node/swap/image-config-swap-fedora.yaml" CONTAINER_RUNTIME_ENDPOINT="unix:///var/run/crio/crio.sock" TEST_ARGS='--kubelet-flags="--fail-swap-on=false --cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/  --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{"name": "crio.log", "journalctl": ["-u", "crio"]}" --feature-gates=NodeSwap=true --service-feature-gates="NodeSwap=true"'

all of the tests passed (for multiple times):

Ran 14 of 793 Specs in 1576.462 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 779 Skipped
PASS

I suspect that the previous problem was due to the fact we lacked the --parallelism=1 parameter that is now added as part of this PR.

/sig node
/cc @kannon92

@k8s-ci-robot k8s-ci-robot requested a review from kannon92 July 1, 2025 12:13
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 1, 2025
@iholder101
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@iholder101: The following commands are available to trigger required jobs:

/test pull-test-infra-gubernator
/test pull-test-infra-misc-image-build-test
/test pull-test-infra-prow-checkconfig
/test pull-test-infra-unit-test
/test pull-test-infra-verify-cri-o
/test pull-test-infra-verify-lint

The following commands are available to trigger optional jobs:

/test pull-test-infra-unit-test-race-detector-nonblocking

Use /test all to run the following jobs that were automatically triggered:

pull-test-infra-gubernator
pull-test-infra-prow-checkconfig
pull-test-infra-unit-test
pull-test-infra-unit-test-race-detector-nonblocking
pull-test-infra-verify-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iholder101, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4bd45e2 into kubernetes:master Jul 1, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

@iholder101: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Start running memory eviction tests on the swap-conformance lane.

This was already tried in #34507 and later reverted in #34558.

However, after trying to run this locally with:

make test-e2e-node PARALLELISM=1 CLEANUP=true DELETE_INSTANCES=true FOCUS="NodeSwap|MemoryAllocatableEviction|PriorityMemoryEvictionOrdering" SKIP="dummy" SSH_USER="core" KUBE_SSH_USER=core REMOTE=true RUNTIME=remote USE_DOCKERIZED_BUILD=false IMAGE_CONFIG_FILE="/workspace/test-infra/jobs/e2e_node/swap/image-config-swap-fedora.yaml" CONTAINER_RUNTIME_ENDPOINT="unix:///var/run/crio/crio.sock" TEST_ARGS='--kubelet-flags="--fail-swap-on=false --cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/  --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{"name": "crio.log", "journalctl": ["-u", "crio"]}" --feature-gates=NodeSwap=true --service-feature-gates="NodeSwap=true"'

all of the tests passed (for multiple times):

Ran 14 of 793 Specs in 1576.462 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 779 Skipped
PASS

I suspect that the previous problem was due to the fact we lacked the --parallelism=1 parameter that is now added as part of this PR.

/sig node
/cc @kannon92

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants