Skip to content

Comments

Remove Image push jobs from sig-release-master-informing#34868

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Rajalakshmi-Girish:remove-push-image-jobs-master-informing
May 28, 2025
Merged

Remove Image push jobs from sig-release-master-informing#34868
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Rajalakshmi-Girish:remove-push-image-jobs-master-informing

Conversation

@Rajalakshmi-Girish
Copy link
Contributor

The image pushes shouldn't be listed in sig-release-master-informing dashboard. They're built adhoc and mostly not from k/k.
They are also listed in a different dedicated tab sig-release-image-pushes
Hence this change is to remove below jobs from sig-release-master-informing dashboard:

  • post-kpromo-push-image
  • post-kubernetes-push-image-etcd
  • post-kubernetes-push-image-pause
  • post-release-push-image-debian-base
  • post-release-push-image-distroless-iptables
  • post-release-push-image-go-runner
  • post-release-push-image-kube-cross
  • post-release-push-image-setcap

Ref Slack Thread
Ref: #34548 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2025
annotations:
testgrid-dashboards: sig-release-releng-blocking, sig-release-master-informing, sig-release-image-pushes, sig-k8s-infra-gcb
testgrid-dashboards: sig-release-releng-blocking, sig-release-image-pushes, sig-k8s-infra-gcb
testgrid-alert-email: k8s-infra-alerts@kubernetes.io, release-managers+alerts@kubernetes.io, release-team@kubernetes.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: probably doesn't need to alert release team? (Good question for the release lead perhaps?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be inclined towards removing this from release team's radar. This falls on the releng side, so it's fine to remove release team from observing these.

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7e63510 into kubernetes:master May 28, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-artifact-promoter.yaml using file config/jobs/image-pushing/releng/k8s-staging-artifact-promoter.yaml
  • key k8s-staging-build-image.yaml using file config/jobs/image-pushing/releng/k8s-staging-build-image.yaml
  • key k8s-staging-kubernetes.yaml using file config/jobs/image-pushing/releng/k8s-staging-kubernetes.yaml
Details

In response to this:

The image pushes shouldn't be listed in sig-release-master-informing dashboard. They're built adhoc and mostly not from k/k.
They are also listed in a different dedicated tab sig-release-image-pushes
Hence this change is to remove below jobs from sig-release-master-informing dashboard:

  • post-kpromo-push-image
  • post-kubernetes-push-image-etcd
  • post-kubernetes-push-image-pause
  • post-release-push-image-debian-base
  • post-release-push-image-distroless-iptables
  • post-release-push-image-go-runner
  • post-release-push-image-kube-cross
  • post-release-push-image-setcap

Ref Slack Thread
Ref: #34548 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants