Skip to content

Conversation

@dgrisonnet
Copy link
Member

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 13, 2025
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims February 13, 2025 15:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 13, 2025
@rexagod
Copy link
Member

rexagod commented Feb 13, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit c9b4d69 into kubernetes:master Feb 13, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@dgrisonnet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key custom-metrics-apiserver-presubmits.yaml using file config/jobs/kubernetes-sigs/custom-metrics-apiserver/custom-metrics-apiserver-presubmits.yaml
Details

In response to this:

This is needed by kubernetes-sigs/custom-metrics-apiserver#192

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants